cid#916075 Unchecked return value from library
cid#916074 silence Unchecked return value
cid#916073 Variable copied when it could be moved
bump to 0.1.2
install whichever of the png, svg and js doxygen files exist
cid#169034 Missing move assignment operator
cid#916055 silence Unchecked return value
cid#916046 Variable copied when it could be moved
cid#916047 Division or modulo by float zero
skip header and footer open and close calls that are out of step
pop the relative column widths too when a table closes
return EPUBPath title by reference
drop an embedded font that has no data or mime type
testCoverImage still looked for image0001.png
Help some epub readers to see the cover page
Help some epub readers to see the cover page
Create new release including direction release
configure: fail to guess build type
It isn't too complex: you just perform your function calls on libepubgen::EPUBTextGenerator and you assert the result (or the lack of it) at the end. I've added a test for this now, see commit 1c4edb690e4ad248d214d199797df5318529f910. Hopefully you can write a similar test for your next fix. :-) And yes, fixing epubchecker warnings is great, thanks for that.
Test for "remove direction property from version 30+"
i'll try. i've never worked with CppUnit before though, so i'll have to read into that. i might also make another merge request down the line to add titles to the individual sections (not strictly required by the standard, but recommended. epubchecker throws warnings if you don't include them).
Fix up whitespace with 'make astyle'
Exclude direction CSS property on EPUB 3
Let me merge this as-is, but please do consider adding a test to cover this, in a follow-up merge quest. :-) Thanks!
Thanks, this looks good. Did you consider covering your change with a test in src/test/EPUBTextGeneratorTest.cpp? You could add an assertXPathNoAttribute() and then this should be straightforward to test. Or I can do that for you, this is your first commit after all. :-)
Exclude direction CSS property on EPUB 3
Avoid accessing static members through instances
Make these member functions static
Use range-based for loop
tdf#120491 EPUBHTMLGenerator: remove not needed <meta content="text/html...">
prepare for a release
bump release
disable werror by default
Make EPUBSpanStyleManager a base calss of EPUBBodyStyleManager.
Enclose <span> with <ruby> if text:ruby-text is set.
The patch looks good to me mostly. A nitpick: please auto auto conservatively: if the type info is already spelled out in the same line, for iterators and for range-based for loops. auto *rubyText = propList["text:ruby-text"]; is a bit hard to read to my simple mind. Otherwise feel free to push the patch.
I didn't catch your point when you said that. Here is the updated patch. However, specifying character style for the ruby text is missing. I plan to fix that in future patches. Is that a good idea to use defineSpan and librevenge:span-id for that purpose? Is there a way to specify default css styles for elements?
Conditional handling of a span based on a property is a misuse of the API. As I said on IRC, the only sort-of-reasonable way to at least partially support ruby with the current API is to enclose the ruby base in a span and pass the ruby text in a property.
There is some issue in the patch. I'll fix that later.
Update the patch with more documentation.
Patch: assertXPath -> CPPUNIT_ASSERT_XPATH to catch the line number.
patch: Implement ruby and rt with openSpan and closeSpan.
refactor: Extract EPUBBodyStyleManager from EPUBSpanStyleManager
Patch: assertXPath -> CPPUNIT_ASSERT_XPATH to catch the line number.
This has been merged
assertXPathContent -> CPPUNIT_ASSERT_XPATH_CONTENT
assertXPath -> CPPUNIT_ASSERT_XPATH to catch the line number.
Patch: assertXPath -> CPPUNIT_ASSERT_XPATH to catch the line number.
Patch: Use an indepednent object for body style manager.
Use an independent object for body style manager.
Patch: Catch the line number where assertCss was called.
The final patch is different, but the problem is fixed.
Patch: assertXPath -> CPPUNIT_ASSERT_XPATH_ATTRIBUTE
assertXPath -> CPPUNIT_ASSERT_XPATH_ATTRIBUTE
Fix incorrect spelling in the commit message.
Patch: Use an indepednent object for body style manager.
Patch: assertXPath -> CPPUNIT_ASSERT_XPATH_ATTRIBUTE
Replace assertCss with CPPUNIT_ASSERT_CSS.
Update patch to define CPPUNIT_ASSERT_CSS macro instead of throw exception.
Patch: Catch the line number where assertCss was called.
Ensure page properties in the page span works.
Always keep page properties when splitting the HTML file.
Support writing-mode for reflowable layout method.
rename EPUBBinarySink to EPUBBinaryContent
rename EPUBCSSSink to EPUBCSSContent
rename EPUBXMLSink to EPUBXMLContent
split EPUBFontManager into separate file
put own header first
drop unused deleter
use make_shared
drop unnecessary typedef
drop typedef
drop unused typedef
iwyu: prune includes
avoid conversion to inches
WaE: unnecessary parentheses in declaration of 'type'
WaE: unnecessary parentheses in declaration of 'types'
WaE: unnecessary parentheses in declaration of 'type'
WaE: unnecessary parentheses in declaration of 'type'
fixed layout: avoid Page <N> entries when chapter names are provided
fixed layout: allow defining chapter names
EPUBImageManager: handle relative and absolute width
EPUBHTMLGenerator: fix invalid XHTML with links at footnote start
EPUBTableStyleManager: avoid vertical-align key without value
EPUBHTMLGenerator: avoid <div> inside <p> and/or <span>
bump release
prepare for a release
WaE: remove unused function
Move EPUBSplitMethod from the generator constructors
EPUBTextGenerator: setOptions() -> setOption() to keep it simple
EPUBTextGenerator: default to EPUB3