Recent changes to bugs

#4 failure build for Windows

Pavel Vatagin — Thu, 06 Aug 2015 12:19:39 -0000

According to the ChangeLog, the MinGW support has been dropped.

Too bad! JsonRpc-Cpp used in our cross-platform project for Linux, OS X and Windows.

However the code compile fine with Microsoft Visual Studio 2015.

No way. MSVC is a proprietary compiler, so we always give preference to GCC.

#4 failure build for Windows

Sebastien Vincent — Tue, 04 Aug 2015 10:54:14 -0000

It appears that MinGW does not have suport for poll() function.

According to the ChangeLog, the MinGW support has been dropped. However the code compile fine with Microsoft Visual Studio 2015.

Anyway if you want to contribute a patch to support MinGW, I will happy to review it.

failure build for Windows

Pavel Vatagin — Mon, 03 Aug 2015 22:25:44 -0000

Failure build for Windows on MXE (http://mxe.cc/).

#3 tcp-server accepting logic non thread-safe in same applications

Sebastien Vincent — Sun, 02 Aug 2015 09:52:37 -0000

status: accepted --> closed-fixed

#3 tcp-server accepting logic non thread-safe in same applications

Sebastien Vincent — Sun, 26 Jul 2015 16:51:33 -0000

status: open --> accepted
assigned_to: Sebastien Vincent
Priority: 5 --> 3

#3 tcp-server accepting logic non thread-safe in same applications

Sebastien Vincent — Sun, 26 Jul 2015 16:51:16 -0000

Thank you for the report.

Yes select() has some limitations, so change to poll() is a good idea.

In your patch, it misses the poll() for the TCP client socket descriptor. But anyway I will definitely replace the select() stuff by poll().

tcp-server accepting logic non thread-safe in same applications

ksotik — Sat, 14 Jun 2014 18:20:49 -0000

In my client-server application I use libevent for a heavily accepting and manipulating with client connections (video streaming application). In your library you are using select() with precalculated max_sock identifier for non-blocking accept new connection, and in some time it can happens situation, when a system generated sock identifier in other program threads can match with your max_sock and then program state will be non consistent. In my patch I replace select() logic to poll() logic without using self generated sock identifier and problem has gone.

tcp-server accepting logic non thread-safe in same applications

ksotik — Sat, 14 Jun 2014 18:20:49 -0000

Ticket 3 has been modified: tcp-server accepting logic non thread-safe in same applications
Edited By: Sebastien Vincent (s-vincent)
Status updated: u'open' => u'accepted'
_priority updated: u'5' => u'3'
Owner updated: None => u's-vincent'

tcp-server accepting logic non thread-safe in same applications

ksotik — Sat, 14 Jun 2014 18:20:49 -0000

Ticket 3 has been modified: tcp-server accepting logic non thread-safe in same applications
Edited By: Sebastien Vincent (s-vincent)
Status updated: u'accepted' => u'closed-fixed'

#2 ms in waitmessage in server is truncated

Sebastien Vincent — Thu, 07 Feb 2013 16:44:38 -0000

status: open --> closed-fixed
milestone: -->