<?xml version="1.0" encoding="utf-8"?>
<feed xml:lang="en" xmlns="http://www.w3.org/2005/Atom"><title>Recent changes to bugs</title><link href="https://sourceforge.net/p/phase10/bugs/" rel="alternate"/><link href="https://sourceforge.net/p/phase10/bugs/feed.atom" rel="self"/><id>https://sourceforge.net/p/phase10/bugs/</id><updated>2013-10-14T13:17:42.035000Z</updated><subtitle>Recent changes to bugs</subtitle><entry><title>#3 You've Broken A Rule</title><link href="https://sourceforge.net/p/phase10/bugs/3/?limit=25#38ea" rel="alternate"/><published>2013-10-14T13:17:42.035000Z</published><updated>2013-10-14T13:17:42.035000Z</updated><author><name>Dennis Muhlestein</name><uri>https://sourceforge.net/u/mulicheng/</uri></author><id>https://sourceforge.neta6604ac002de703446056342765f22740afc889e</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;This isn't actually a bug.. it's just a lack in the documentation and a needed enhancement in the logic when you submit the phase.  The issue is that you have to re-order the cards in the order the of the current phase.  So put your set of 4 first and then your run of for and then you should be able to submit them.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>You've Broken A Rule</title><link href="https://sourceforge.net/p/phase10/bugs/3/" rel="alternate"/><published>2013-06-16T01:22:20.621000Z</published><updated>2013-06-16T01:22:20.621000Z</updated><author><name>Malkierian</name><uri>https://sourceforge.net/u/malkierian/</uri></author><id>https://sourceforge.net8d9766fb05008c7b1ac2ce9bb9eeb74098eff62d</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;But which one?&lt;br /&gt;
&lt;a href="http://gyazo.com/0c1c65b2395918e97c3dab4bfadf5211" rel="nofollow"&gt;http://gyazo.com/0c1c65b2395918e97c3dab4bfadf5211&lt;/a&gt;&lt;br /&gt;
It looks to ME like I have everything I need, but no matter what order I click the cards in or which box I try to drag them to, it keeps telling me this.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Process does not end</title><link href="https://sourceforge.net/p/phase10/bugs/2/" rel="alternate"/><published>2009-01-10T19:10:35Z</published><updated>2009-01-10T19:10:35Z</updated><author><name>Keith Blackie</name><uri>https://sourceforge.net/u/keb1965/</uri></author><id>https://sourceforge.net7f337c34a86d8946e3ba93ebdd953af75fc7440c</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;On WinXP when closing the application using the control box, the process does not end, however, when closing the application using the "Exit" menu item, the process is ended correctly.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Phase validation error</title><link href="https://sourceforge.net/p/phase10/bugs/1/" rel="alternate"/><published>2009-01-07T16:20:00Z</published><updated>2009-01-07T16:20:00Z</updated><author><name>Keith Blackie</name><uri>https://sourceforge.net/u/keb1965/</uri></author><id>https://sourceforge.nete36f8beaceb0f2a33038aaeb388f146f42c090ce</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;A known error when validating the phase in the selected cards from the hand arises when the phases are not in the same order as the phase description.&lt;/p&gt;
&lt;p&gt;Example:&lt;br /&gt;
The phase description is a "Set of 5" and "Set of 3"&lt;/p&gt;
&lt;p&gt;Cards in the hand are: G1 Y1 Y1 R4 Y4 R4 G10 B10 R10 B10 BW&lt;/p&gt;
&lt;p&gt;Clearly the phase would be valid if the user selects the set of 1s or 4s and the set of 10s with the wild, but since the set of 10s is placed in the second set (a Set of 3) both parts of the phase fail validation.&lt;/p&gt;
&lt;p&gt;A workaround for the user would be to sort the hand so the Set of 5 is before the Set of 3 in the hand, as such:&lt;/p&gt;
&lt;p&gt;G10 B10 R10 B10 BW G1 Y1 Y1 R4 Y4 R4&lt;/p&gt;
&lt;p&gt;The portion of code creating this issue is likely located in ../src/Game/Phase.cpp&lt;/p&gt;
&lt;p&gt;I have identified a possible solution that may be applied to Phase::IsValid to resolve this issue.&lt;/p&gt;
&lt;p&gt;bool Phase::isValid(THand* phaseA, THand* phaseB, int phase) {&lt;br /&gt;
PHASE_TYPE type1, type2;&lt;br /&gt;
int size1,size2;&lt;br /&gt;
phaseRequirements ( phase, &amp;amp;type1, &amp;amp;size1, &amp;amp;type2, &amp;amp;size2 );&lt;br /&gt;
// there is always part1 required&lt;br /&gt;
wxASSERT ( type1 != ptNONE );&lt;br /&gt;
if ( !isValid ( phaseA, type1, size1 ) &amp;amp;&amp;amp; !isValid ( phaseB, type1, size1 ) )&lt;br /&gt;
return false;&lt;br /&gt;
if ( type2 != ptNONE &amp;amp;&amp;amp; ( !isValid ( phaseB, type2, size2 ) &amp;amp;&amp;amp; !isValid ( phaseA, type2, size2 ) ) ) &lt;br /&gt;
return false;&lt;br /&gt;
return true;&lt;br /&gt;
}&lt;/p&gt;&lt;/div&gt;</summary></entry></feed>