Recent changes to bugs

CaptureConditions.FNumber wrong case

2004-02-02T00:52:38Z

FNumber is listed as CaptureConditions.FNumber in
PmtMetadataKeysForExif.pdf, but
CaptureConditions.Fnumber in the souce.

If you try to get CaptureConditions.FNumber, the call
fails.

PMT Type Table Incorrect

2002-12-17T17:23:43Z

The PMT Type Table, which is part of the PmtMetadataKeysForExif and PmtMetadataKeysForTiff
documents has two incorrect entries. Particularly, the entries 5 and 12 are incorrect.

For entry 5, there are 2 keys that must have changes made to their types: CaptureDevice.FID and
SceneContent.GroupCaption.UserSelectGroupTitle. For entry 12, there are 2 keys that must have
changes made to their types: CaptureDevice.CFAPattern and ImageContainer.TiffepVersion. The exact
changes to the types needs to be investigated.

Entries 5 and 12 in the PMT Type Table needs to be removed, and the PmtMetadataKeysForExif and
PmtMetadataKeysForTiff documents need to be updated to reflect the changes in the PMT Type Table.

APP3 Invalid

2002-12-13T18:31:36Z

In the 103h release, the exif_copy.jpg file has an invalid APP3, according to Exif Verifier.

Rob and I looked into this, and discovered that two tags are incorrect in the translation table.
ImageContainer.SourceImageFileName should be changed from tag 201 to 50201.
ImageContainer.SourceImageVolumeName should be changed from tag 202 to 50202.

Making this change will hopefully clear up the corrupt APP3. Try it and see. If APP3 is still corrupt,
resolve any other issues.

Also make sure this change happens in the MAIN branch.

Created by DKR on 12/13/03

Factory Fix for MacIntosh Build

2002-11-04T15:11:21Z

Change the factory from using EK_PROVIDE and EK_REQUIRE to initialization in a way that works ok
on the MacIntosh build. Even though it appears that CodeWarrior is acting flakey with provide and
require, a work around needs to be implemented, since we're getting an empty Translator factory in the
current test programs.

.NET Build Change

2002-11-04T15:06:44Z

In 103ebugfixes branch, change the PmtMetadataT.h file to allow for correct .NET DLL builds. This
means simply ensuring that the keyword 'inline' is used on each templated method.

Throw Error On TIFF Open

2002-11-04T15:02:06Z

In the 103ebugfixes branch, throw an error if the TIFF Accessor is attempted to be opened in read/write
mode, since that mode is not currently supported.

Key Fixes from Documentation Findings

2002-11-04T14:57:57Z

In the 103ebugfixes branch, make the following changes in PMT's Schema and Translation Table. These
findings are the result of Kathy's documentation work, in creating the new documentation for PMT's keys:

Updated keys in Schema file PmtDefaultDefinitions.xsd
This also affects the PmtDefaultDefinitions.h, as expected.
-------------------------------------------------------------------------------------

SubjectArea changed from pmt_vuint32 to pmt_vuint16
ImageSource changed from pmt_vuint8 to usignedByte
ImageSourceEK changed from unsignedByte to unsignedShort
ReferenceBlackWhite changed from pmt_vuint8 to pmt_vfloat
SoundType changed from byte to unsignedShort
StripByteCounts changed from unsignedInt to pmt_vuint32
StripOffsets changed from unsignedInt to pmt_vuint32
RowsPerStrip changed form unsignedShort to unsignedInt
StripByteCounts changed from unsignedInt to pmt_vuint32
StripOffsets changed from unsignedInt to pmt_vuint32
SubjectLocation changed from pmt_vuint32 to pmt_vuint16

Changes to PmtTranslationTbl.h
------------------------------------------------
CaptureConditions.ImageNumber TIFF Translator changed from builtin2ushort to builtin2ulong
CaptureConditions.ShutterSpeed TIFF (both entries) Type changed from rational to urational
CaptureConditions.SubjectDistance TIFF (both entries) Type changed from urational to rational
<ARRAYSIZE> entries removed
ImageContainer.Thumbnail.Height EXIF Type changed from ushort to ulong and Translator changed from
builtin2ushort to builtin2ulong.
ImageContainer.Thumbnail.RowsPerStrip EXIF Type changed from ushort to ulong and Translator
changed from builtin2ushort to builtin2ulong.
ImageContainer.Thumbnail.StripbyteCounts EXIF Type changed from ushort to unlong and Translator
changed from builtin2ushort to builtin2ulong.
ImageContainer.Thumbnail.Width EXIF Type changed from ushort to ulong and Translator changed from
builtin2ushort to builtin2ulong.
SceneContent.GPS.VersionID EXIF Type changed from undefined to ushort and Translator changed from
builtin2undefined to builtin2ushort & TIFF Type changed from byte to ubyte and Translator changed from
builtin2char to builtin2uchar.
SceneContent.GroupCaption.UserSelectGroupTitle EXIF Type changed from undefined to ascii and
Translator changed from builtin2undefined to builtin2ascii.

vectors of ubyte and byte

2002-09-24T16:00:50Z

KIES Toolkits is not correctly handling these data
types. Returns the first value in the vector correctly
but garbage values in the rest.

SHORT or LONG Types

2002-09-18T20:44:31Z

There are certain keys that can be of type SHORT or LONG in Exif.

Our code currently does not handle the case when an Exif file returns such a key stored as type SHORT.

An example key that's like this is ImageContainer.Thumbnail.Width. The file KodakDC260.jpg stores this
key as a SHORT and exhibits the ill-behavior by returning an invalid value.

Exif Accessor Read-Only Mode Not Working

2002-09-13T17:54:15Z

There are two parts to this bug, both having to do with PMT_READONLY mode not working properly in
PMT. The two parts to this bug are listed next to "1.)" and "2.)" below.

1.) If an Exif Accessor is opened in PMT_READONLY mode (the default), no errors are thrown (even if
throwErrors() = true; is called) when an attempt to call writeMetadata(...) is made. It is true, that the file
on disk is not modified, but an error of some type should be thrown in such cases.

This can be illustrated by copying the following code into the AccessorTest test program. Notice the
code below next to the three exclamation (!!!) points.

#include "PmtDefinitionInterpreter.h"
#include "PmtAccessor.h"
#include "PmtMisc.h"
// Make sure the implementations are linked and
// loaded into the Accessor factory.
#if defined(HAVE_KIESEXIF) || defined(HAVE_OPENEXIF)
PMT_REQUIRE(PmtExifAccessor)
#endif

int main()
{
try
{
string inputImageFile = "Kodak_DC220.jpg";
string outputImageFile = "test2.jpg";

// Create the Logical Defn Interpreter
// and load the default metadata defns.
PmtLogicalDefinitionInterpreter interpreter;
interpreter.load();

PmtCopyFile(inputImageFile.c_str(), outputImageFile.c_str(), true);

PmtAccessorPtr acc = PmtAccessor::create(PMT_FORMAT_EXIF);
PmtMetadataPtr mdRoot = PmtMetadata::create();
PmtMetadataPtr md;

acc->throwErrors() = true;

md = mdRoot->getMetadatum("CaptureConditions.Aperture");

// !!! This is where if PMT_READWRITE is not specified, we would
// expect to get an error (but don't)!
acc->open(outputImageFile.c_str());
//acc->open(outputImageFile.c_str(), PMT_READWRITE);

acc->readMetadata(md);
cout << "Value before write should be 4.5" << endl;
md->show();

md->setValueStr(EK_L("2.8"));
acc->writeMetadata(md);

acc->close();
acc->open(outputImageFile.c_str());
mdRoot->deleteMetadata("CaptureConditions.Aperture");
acc->readMetadata(md);
cout << "Value after write should be 2.8" << endl;
md->show();
}
catch (PmtError& e)
{
cout << e << endl;
exit(1);
}
catch (...)
{
cout << "**** Some Exception caught." << endl;
}

return 0;
}

2.) If the file is not closed, after a writeMetadata(...) call, a subsequent call to readMetadata(...) returns
the incorrect value. It acts as if the writeMetadata(...) was successfull. This is incorrect because a.) the
file does not really have the value returned from readMetadata(...), and b.) the value returned is probably
cached in the Kies toolkits memory.

See the following code below, noting the three exclamation points (!!!)...

int main()
{
try
{
string inputImageFile = "Kodak_DC220.jpg";
string outputImageFile = "test2.jpg";

// Create the Logical Defn Interpreter
// and load the default metadata defns.
PmtLogicalDefinitionInterpreter interpreter;
interpreter.load();

PmtCopyFile(inputImageFile.c_str(), outputImageFile.c_str(), true);

PmtAccessorPtr acc = PmtAccessor::create(PMT_FORMAT_EXIF);
PmtMetadataPtr mdRoot = PmtMetadata::create();
PmtMetadataPtr md;

acc->throwErrors() = true;

md = mdRoot->getMetadatum("CaptureConditions.Aperture");

acc->open(outputImageFile.c_str());
md->setValueStr(EK_L("2.8"));
acc->writeMetadata(md);

mdRoot->deleteMetadata("CaptureConditions.Aperture");
acc->readMetadata(md);

//!!! This value should NOT be 2.8, since modification of the file
// will not happen on disk. The returned value of 2.8 is only
// laying around in the memory of the Kies toolkit.
cout << "Value after write should NOT be 2.8" << endl;
md->show();
}
catch (PmtError& e)
{
cout << e << endl;
exit(1);
}
catch (...)
{
cout << "**** Some Exception caught." << endl;
}

return 0;
}