Recent changes to bugs

#6 load_dsm.cpp

Andrei — Sat, 11 Jan 2014 08:18:39 -0000

Sorry for style.
line 112: "Order[iOrd] = (BYTE)((iOrd < psong->numord) ? psong->orders[iOrd] : 0xFF);"

load_dsm.cpp

Andrei — Sat, 11 Jan 2014 08:14:22 -0000

qmetro-code-115\src\alarm\libmodplug\load_dsm.cpp line 112

for (UINT iOrd=0; iOrd[iOrd] = (BYTE)((iOrd < psong->numord) ? psong->orders[iOrd] : 0xFF);
}

Buffer is accessed out of bounds: psong.orders

BYTE orders[128];

define MAX_ORDERS 256

#5 load_pat.cpp

Leo — Thu, 02 Jan 2014 20:52:02 -0000

Okay, thanks for checking, I'm glad that nothing else is found :)
Happy New Year! :D

#5 load_pat.cpp

Anonymous — Thu, 02 Jan 2014 13:16:33 -0000

"How you get an error in "load_pat.cpp", if I dont use it in project"

I just used a static analyzer for source code. I use cppcheck. Thanks.

#4 Fedora compile error

Leo — Wed, 01 Jan 2014 23:54:37 -0000

status: open --> closed

#5 load_pat.cpp

Leo — Wed, 01 Jan 2014 23:53:49 -0000

status: open --> closed

#5 load_pat.cpp

Leo — Wed, 01 Jan 2014 23:53:11 -0000

Hello,

You can just remove "alarm module" from project, comment line qmetro.pro:9:
It's was disabled by default...
How you get an error in "load_pat.cpp", if I dont use it in project:
alarm.pri:77 is commented (because I use "MODPLUG_BASIC_SUPPORT=1" alarm.pri:28)
It's not my code - see "libmodplug", maybe it's already fixed.

Thanks.

load_pat.cpp

Andrei — Wed, 01 Jan 2014 14:20:27 -0000

qmetro-code-115\src\alarm\libmodplug\load_pat.cpp line 564:

strncpy(hw->reserved, hl.reserved, 36);

Buffer is accessed out of bounds: hw.reserved.

line 128 : char reserved[32];

Thanks.

load_pat.cpp

Andrei — Wed, 01 Jan 2014 14:20:27 -0000

Ticket 5 has been modified: load_pat.cpp
Edited By: Leo (n0idea)
Status updated: u'open' => u'closed'

Fedora compile error

Anonymous — Sun, 31 Mar 2013 11:52:17 -0000

bash-4.2$ cat qmetro-0.6.5.patch
--- qmetro.pro.orig 2013-03-31 15:40:07.882619079 +0400
+++ qmetro.pro 2013-03-31 15:41:20.130474604 +0400
@@ -86,6 +86,7 @@
map.path = $$DATADIR/map
skin.path = $$DATADIR/skin
}
+ LIBS += -lz
}

macx{
--- rc/alarm.pri.orig 2013-03-31 15:32:18.413147987 +0400
+++ rc/alarm.pri 2013-03-31 15:50:50.533486048 +0400
@@ -8,14 +8,6 @@
CONFIG += mobility
MOBILITY = multimedia

-unix:!macx:!maemo5:!contains(MEEGO_EDITION,harmattan):!symbian {
-QT -= multimedia
-INCLUDEPATH += /usr/include/QtMultimediaKit \ - /usr/include/QtMobility
-#LIBS += -lQtMultimediaKit
-}
-
-
DEFINES += QMETRO_HAVE_ALARM=1

DEFINES += HAVE_CONFIG_H=1 \