Custom Actions Action Data not current - Advanced Installer Community

We’re moving our forums to a new platform.

You can still browse and search existing topics, but you can no longer create new topics or post replies.

For questions, technical issues, or feature requests, please don’t hesitate to contact our support team at support@advancedinstaller.com.

Thank you for your understanding!

invalidptr
Posts: 79
Joined: Thu Nov 18, 2010 7:10 pm

Custom Actions Action Data not current

- I've placed a VBScript in InstallExecuteSequence -> Commit.
- I've made sure Execute Options is set to Immediate execution.
- Action Data -> Windows Installer Property -> User Interface -> FirstName

The problem is the value of FirstName when I query it with VBScript is the original default value I set FirstName to in AI and not the value the user changed it to in my Custom Dialog Edit control.

What am I missing?
Thanks
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Custom Actions Action Data not current

Hello and welcome to the Advanced Installer Forums,

From what I see, you are using a private property(FirstName) instead of public property(something like FIRST_NAME) in your VBScript.
The difference between private and public properties is that the value of a public property is passed on from the InstallUISequence (in which the dialogs are showed) to the InstallExecute Sequence (in which the system is modified).

Regards,
Mihai
Last edited by mihai.petcu on Mon Dec 06, 2010 1:04 pm, edited 1 time in total.
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
invalidptr
Posts: 79
Joined: Thu Nov 18, 2010 7:10 pm

Re: Custom Actions Action Data not current

Thanks for the quick response Mihai.

Your response wasn't clear but this section of the help file cleared up my confusion.
The property must be public (all uppercase letters) because properties that are set by the user interface during the installation and then passed to the installation's execution phase must be public.
invalidptr
Posts: 79
Joined: Thu Nov 18, 2010 7:10 pm

Re: Custom Actions Action Data not current

This is an interesting observation. In AI 8.0.2 I have three dialogs I needed to change because of this. In all three I followed the same process.

- Select edit control
- Highlight property name
- Change the property name to all upper-case then press enter. ContactTitle become CONTACT_TITLE

On two of the dialogs the Default Value disappeared.
On one of the dialogs the Default Value is kept.

Looking at the .aip file I noticed:
- When the Default Value disappeared there are two entries in <COMPONENT cid="caphyon.advinst.msicomp.MsiPropsComponent">. The old name (ContactTitle) and the new name (CONTACT_TITLE)
- When the Default Value is kept there is one entry in <COMPONENT cid="caphyon.advinst.msicomp.MsiPropsComponent">. It's like a rename... LocBusinessName goes away and LOC_BUSINESS_NAME is added.

I can't a setting that would cause this. Is this a bug?
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Custom Actions Action Data not current

Hello,

I have tested this and I can confirm this behavior is caused by a bug in Advanced Installer. Thank you for reporting it, I have informed the development team and a fix will be available in the next version.
This is happening only when an Edit Box control is copied. As a workaround, please try to add all your Edit Box controls directly from the Toolbox and rename the property name just the first time.
Another workaround would be edit the Default Value for the control's public property from the "Install Parameters" page.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
invalidptr
Posts: 79
Joined: Thu Nov 18, 2010 7:10 pm

Re: Custom Actions Action Data not current

Great catch on "when an Edit Box control is copied." Glad you could reproduce.

Interesting you should bring up the "Install Parameters" page. None of my values appear there. I even had an issue where I created a new Property on the Install Parameters and it would "disappear" right away. I could see it the XML but not in the GUI. Can't reproduce at the moment. But the fact remains - I don't see my Properties there. Should I have created them there first?
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Custom Actions Action Data not current

Hello,

Yes, you are correct, the properties don't always appear in the "Install Parameters" page and they shouldn't appear at all as a matter of fact. This a repercussion of the bug.
Please use my first workaround suggestion to get past this.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Common Problems”