Hiding sensitive property in MSI log used in a Custom Action - Advanced Installer Community
sjeslis
Posts: 308
Joined: Mon Aug 22, 2011 11:40 pm
Contact: Website

Hiding sensitive property in MSI log used in a Custom Action

I have a "Call function from attached DLL" custom action that runs CreateExeProcess. The Action Data contains a password I want to hide in the MSI Log. I've gotten rid of most instances by:

a) using a property to hold the value and marking it as "Hide Property".
b) Adding the associated CustomActionData property to MsiHiddenProperties

BUT

I still have one line left I can't fix: (note: the "1****1" is the actual default value of the property (some made up string I made for this example):

MSI (s) (C0:2C) [10:55:17:427]: Executing op: CustomActionSchedule(Action=Obfuscate_Logi_Settings,ActionType=1537,Source=BinaryData,Target=CreateExeProcess,CustomActionData=C:\Program Files (x86)\Cicero Inc\Reports\LogiXML Scheduler Service\>C:\Program Files (x86)\Cicero Inc\Reports\LogiObfuscation.exe "C:\Program Files (x86)\Cicero Inc\Reports\LogiXML Scheduler Service\_Settings.lgx" 1****1 /obfuscate)
Scott Jeslis
Senior Software Engineer
Cicero, Inc.
sjeslis
Posts: 308
Joined: Mon Aug 22, 2011 11:40 pm
Contact: Website

Re: Hiding sensitive property in MSI log used in a Custom Ac

I also set the 8192 bit in the type table for the custom action:
obfuscate.JPG
obfuscate.JPG (19.48 KiB) Viewed 6697 times
Maybe that wasn't the correct place?

This MSI Help isn't that clear:

https://msdn.microsoft.com/en-us/librar ... 85%29.aspx

Maybe I need to set the 8192 bit here as well? :
obfuscate2.JPG
obfuscate2.JPG (16.11 KiB) Viewed 6697 times
Scott Jeslis
Senior Software Engineer
Cicero, Inc.
Daniel
Posts: 8283
Joined: Mon Apr 02, 2012 1:11 pm
Contact: Website

Re: Hiding sensitive property in MSI log used in a Custom Action

Hello Scott,

I apologize for my delayed reply. We had a release this week and we were a bit busy.

To make sure your password property value is not written in the log file you should proceed like this:
1. add the property in "Install Parameters" page and enable its "Hide property" flag
2. add a second property having the same name as your custom action (e.g. "aicustact.dll" added in "Custom Actions" page) and enable its "Hide property" flag too

NOTE: this step is required "because the installer sets the value of CustomActionData from a property with the same name as the custom action". So, the above property should be declared as hidden too, otherwise its value will appear in the log.

3. add the "msidbCustomActionTypeHideTarget" flag value to the "Type" field of your action (e.g. "aicustact.dll") from "CustomAction" table. Just go to "Table Editor" page, select the "CustomAction" table, select your custom action row and increase the value from "Type" field with 8192.

Let us know if this helped, otherwise please send us the .AIP (project file) and a verbose log of the installation to support at advancedinstaller dot com so we can investigate them.

All the best,
Daniel
Daniel Radu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Common Problems”