Recent changes to bugs

buffered reading

2003-01-28T16:21:06Z

The start method had to be changed to work properly. If
some dataRead returned a length of data read below the
buffer size, the start method has interpreted this as
being at the end of the file, which is completly wrong.
Changed it to the comparison against a returned length
of 0 which indicates "nothing read".

- start
{
for (;;) {
int bytes_read, done;
void *buff = XML_GetBuffer(parser, bufsize);

if (buff == NULL)
[self errorHandler:XML_GetErrorCode(parser)];

bytes_read = [self dataRead:buff :bufsize];
//done = (bytes_read < bufsize);
done = (bytes_read == 0); // <<--- <<--- <<---

if (!XML_ParseBuffer(parser, bytes_read, done))
[self errorHandler:XML_GetErrorCode(parser)];
if (done)
break;
}
}

method return values

2002-11-26T15:35:25Z

Many of the methods defined in XMLParser class don't have an explicited return value. My compiler (gcc 3 on MacOSX) assumes an integer return value in this case.
However, some of the methods don't contain a return statement, which leads to compiler errors.
I suggest you make the return types explicit:
'(int) foo' instead of just 'foo'.
Also you should include explicit return statements in the implementations of the methods.
Of course I have solved these problems in my local copies, but I think it would help the whole ObjC community if it is solved here.

Cheers,

Rudi Angela

Initialization method

2002-11-26T15:27:34Z

I noticed that when I subclassed the XMLParser class, my class's init method was not being called. So I looked into XMLParser.m for the cause. I found that in the XMLParser initializer called init:encoding:sep:bs: the init method of the superclass was called:
[super init].

It would be better if init was called on XMLParser instead of it's superclass's:
[self init]

That way my subclass's init would get called.
I suggest you consider this, as subclassing the init method is a common practice in ObjC coding.

Cheers,

Rudi Angela