Recent changes to patches

lgc-pg: data conversion broken on big endian hosts (segfault)

Piotr Kubaj — Thu, 12 Nov 2026 13:14:45 -0000

lgc-pg 1.4.4 (and current SVN trunk) segfaults on big endian hosts while
converting the PG data, seen on FreeBSD/powerpc64:

lgc-pg --separate-bridges -s pg-data -d <datadir>
... Segmentation fault

Two things in lgc-pg only work on little endian:

The PG files are read a byte or two at a time into ints with
_fread(&intvar, 1 or 2, 1, file) and then swapped with SDL_SwapLE16.
On big endian the bytes land in the high end of the int, so the 16 bit
swap only sees zeroes and byte reads come out shifted by 24 bits.
Palette indices >= 0x80 become negative and pal[id] in
shp_read_palette writes outside the array, which is the crash.
set_pixel/get_pixel in shp.c memcpy the first BytesPerPixel bytes of an
int, which are the high bytes on big endian, so all icons come out
black.

The attached patch moves partial reads to the low end of the destination
inside the _fread macro (keeps the little endian layout the callers
expect, so no call site changes) and makes set_pixel/get_pixel copy from
the low end of the int. Both are no-ops on little endian. With it the
data converted on powerpc64 is byte for byte identical to the amd64
output (all 203 files under share/lgeneral, text and BMP).

#4 compile fix to MacOS support

Michael Speck — Wed, 08 Jun 2022 17:31:12 -0000

status: open --> closed

compile fix to MacOS support

sergey — Thu, 02 Jun 2022 19:15:02 -0000

Hi,
I would like to propose a small improvement to make lgeneral compatible with modern MacOS X.
There is a small bug in ./configure script with 'mkdir check'

==> ./configure --prefix=/opt/homebrew/Cellar/lgeneral/1.4.4 --libdir=/opt/homebrew/Cellar/lgeneral/1.4.4/lib --disable-sdltest
==> make install
Last 15 lines from /Users/koryaga/Library/Logs/Homebrew/lgeneral/02.make:
../config.h:566:12: fatal error: 'direct.h' file not found
#  include <direct.h>
           ^~~~~~~~~~
In file included from portability.c:27:
../config.h:566:12: fatal error: 'direct.h' file not found
#  include <direct.h>
           ^~~~~~~~~~
1 error generated.
make[1]: *** [paths.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 error generated.
1 error generated.
make[1]: *** [portability.o] Error 1
make[1]: *** [localize.o] Error 1
make: *** [install-recursive] Error 1

The problem is absence of extra header which is needed for Mac OS (#include <sys stat.h="">).
Is it possible to add it to configure.ac? I believe it is safe for other platforms as well (Linux, BSD)</sys>

38c38
< AC_TRY_COMPILE([#include <unistd.h>], [mkdir("test", 0777)], [ac_mkdir_perm_broken=no])
---
> AC_TRY_COMPILE([#include <unistd.h>,#include <sys/stat.h>], [mkdir("test", 0777)], [ac_mkdir_perm_broken=no])

I am trying to add lgeneral to homebrew infrastructure, and this small defects is a blocker for that.
https://github.com/Homebrew/homebrew-core/pull/102434#discussion_r886969209
Thank you.

compile fix to MacOS support

sergey — Thu, 02 Jun 2022 19:15:02 -0000

Ticket 4 has been modified: compile fix to MacOS support
Edited By: Michael Speck (kulkanie)
Status updated: 'open' => 'closed'

#2 Patch for lgeneral 1.2.3 due to bug write to unalloc'ed mem

Michael Speck — Sun, 13 Sep 2015 11:57:01 -0000

status: open --> closed
Group: --> Unstable_(example)

#1 Patch for Lgeneral 1.2.3 seg. fault bug

Michael Speck — Sun, 13 Sep 2015 11:35:46 -0000

status: open --> closed
Group: --> Unstable_(example)

#1 Patch for Lgeneral 1.2.3 seg. fault bug

Michael Speck — Sun, 13 Sep 2015 11:35:35 -0000

three years later... sorry I just read this now. applied it, thanks!

#3 win32/mingw build impovements

Michael Speck — Sun, 13 Sep 2015 11:25:22 -0000

status: open --> closed

win32/mingw build impovements

Ivan Baidakou (dmol) — Sun, 06 Sep 2015 12:50:53 -0000

Hello I was able to create win32 build using mingw. Please, apply the patches into upstread.

The 01-sdl.patch just renames shipped "sdl.h" and "sdl.c", because windows filesystem is filename case insentisive, and instead of "SDL.h" (from SDL library) is included the shipped "sdl.h", and no successfull compilation is possible. I just rename to "lg-sdl.h" and "lg-sdl.c"

The 02-mkdir.patch is more advanced way to allow use 2-argumented mkdir (it takes only 1 argument in windows).

So via 03-config.patch we don't need any win32-specific code, because all is hidded in includes/macroses now.

The 04-no_installdir.patch isn't actuall patch for inclusion, but an request to enhance autoconf/automake (I'm not very familiar with them) to do not define INSTALLDIR, to allow build portalbe win32-build, i.e. it will look for resources relative to the executable (lgeneral.exe). Could you. please, do that?

The 05-fopen-binary.patch improves fopen call: on unices there is no difference between "open file" and "open file in binary mode" (the last one is always used), while on windows there is a difference. So, the patch forces binary file open on all platforms. It will have any not effect on unices.

Thanks, waiting your comments :)

wbr, Ivan Baidakou

win32/mingw build impovements

Ivan Baidakou (dmol) — Sun, 06 Sep 2015 12:50:53 -0000

Ticket 3 has been modified: win32/mingw build impovements
Edited By: Michael Speck (kulkanie)
Status updated: u'open' => u'closed'