Recent changes to bugs

iptc-data.c:607: poor error checking ?

dcb — Thu, 22 Dec 2016 17:13:38 -0000

[iptc-data.c:607]: (style) Checking if unsigned variable 'i' is less than zero.

Source code is

i = iptc_data_dataset_index (data, dataset);
if (i < 0) return -1;

but

unsigned int i;

Suggest put return value from function into local variable
of type int, then sanity check it >= 0, then write it into
local variable i.

[pyiptcdata.c:172]: (style) Checking if unsigned variable 'old_ps3_len' is less than zero.

Probable duplicate.

Compiling error on Windows (MSYS+MinGW

Vincent TORRI — Thu, 18 Feb 2010 05:45:51 -0000

When compiling libiptcdata on Windows, using MSYS+MinGW, I get 2 undefined references because of link() and chown() in main.c (respectively lines 835 and 850)

Instead of link(), we can use CreateHardLink() which is more or less the same thing, with 2 limitations : it works only with Windows 2000 or above, and only with NTFS. Instead of

if (link (filename, bakfile) < 0)

we can do

if (CreateHardLink(bakfile, filename, NULL))

guarded by _WIN32, or alternatively:

#ifdef _WIN32
static int link(const char *oldpath, const char *newpath)
{
if (CreateHardLink(newpath, oldpath, NULL))
return -1;
else
return 0;
}
#endif

so that the code is not modified, and windows.h should be included like that:

#ifdef _WIN32
#define _WIN32_WINNT 0x0500
#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#undef WIN32_LEAN_AND_MEAN
#endif

about chown, maybe the following link can be of some help :

http://wwwthep.physik.uni-mainz.de/~frink/chown/readme.html#concept

IptcLog memory leak - solution included

Justin — Sat, 08 Aug 2009 21:02:38 -0000

The following sequence of code leaks memory:

IptcLog* iptcLog = iptc_log_new();
iptc_log_free( iptcLog );

The problem is that iptc_log_free() does not release log->mem - only the IptcLog itself. This can be resolved by changing iptc_log_free() to:

void
iptc_log_free (IptcLog *log)
{
if (!log) return;
{
IptcMem *mem = log->mem;
iptc_mem_free (log->mem, log);
iptc_mem_unref (mem);
}
}

Italian translation missing

Milo — Sun, 07 Jun 2009 12:55:22 -0000

The Italian translation for libiptcdata is missing. I'm attaching the Italian translations made by the Italian Ubuntu translation team.

A note:
I noticed that the strings from the iptc/ directory are missing in the pot file inside the po/ directory where there are only the one from libiptcdata/.

dataset segfault in Python for unknown tags

Sean D. Upton — Thu, 21 Aug 2008 17:15:48 -0000

Python binding use of latest stable release appears to segfault on retrieval of dataset title attribute for an unknown tag in a JPEG. The tag in question, 221 (Photo Mechanic produced the image) seems to be at fault. Removing this tag (via reassembling the IPTC data block and all segments back into a new JPEG) removes the segfault. Python bindings currently appear to have trouble with a NULL tag info returned by iptc_tag_get_info(); the library should robustly substitute a default or generated title when none exists.

Python .save() fails if photo not on same filesystem as /tmp

Chris Mayo — Sat, 18 Aug 2007 18:34:28 -0000

Tested on Linux with libiptcdata-1.0.2. Data object.save() fails with:

IOError: [Errno 18] Invalid cross-device link: 'photo.jpg'

iptc_data_new_from_jpeg not working

Anonymous — Thu, 28 Sep 2006 19:11:55 -0000

iptc_data_new_from_jpeg is not working, because it
don't open correctly the file. The fopen must use "rb"
and not "r".