<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"><channel><title>Recent changes to patches</title><link>https://sourceforge.net/p/marathon/patches/</link><description>Recent changes to patches</description><atom:link href="https://sourceforge.net/p/marathon/patches/feed.rss" rel="self"/><language>en</language><lastBuildDate>Sun, 28 Jun 2015 15:01:48 -0000</lastBuildDate><atom:link href="https://sourceforge.net/p/marathon/patches/feed.rss" rel="self" type="application/rss+xml"/><item><title>#31 Fixing some GCC compiler warnings</title><link>https://sourceforge.net/p/marathon/patches/31/?limit=25#0383</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;Still learning, but I'll try my best. ;-)&lt;br /&gt;
Thanks for the advice.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Sun, 28 Jun 2015 15:01:48 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net3c7784b31cdfcda23016344f2fda46cd3a08d7d6</guid></item><item><title>#29 Fix for `make distclean' not working properly</title><link>https://sourceforge.net/p/marathon/patches/29/?limit=25#8582</link><description>&lt;div class="markdown_content"&gt;&lt;ul&gt;
&lt;li&gt;&lt;strong&gt;status&lt;/strong&gt;: open --&amp;gt; closed-fixed&lt;/li&gt;
&lt;/ul&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Jeremiah Morris</dc:creator><pubDate>Sun, 28 Jun 2015 03:58:11 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net2076b1a513a2d12f773d4f809511982617c78735</guid></item><item><title>#31 Fixing some GCC compiler warnings</title><link>https://sourceforge.net/p/marathon/patches/31/?limit=25#bc99</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;Thank you for submitting these! As you've seen, most of the warnings you identified are addressed now in trunk. I greatly appreciate your dedication, and hope you will continue to have fun hacking on Aleph One and sending in patches. :D&lt;/p&gt;
&lt;p&gt;In the spirit of encouragement and improvement, please take this bit of advice: don't be so hasty to silence compiler warnings that you wind up hiding underlying problems in the code. Some of the flagged spots in Aleph One had inadequate error checking or other issues, and the warning did its job in calling attention to poor-quality code, but the patches failed to address the deeper causes. Sometimes, half a fix isn't better than none.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Jeremiah Morris</dc:creator><pubDate>Sun, 28 Jun 2015 01:14:16 -0000</pubDate><guid isPermaLink="false">https://sourceforge.netbca1d4a323dc5c67c24d6e3edbbd4adcb2dac823</guid></item><item><title>#29 Fix for `make distclean' not working properly</title><link>https://sourceforge.net/p/marathon/patches/29/?limit=25#ff8b</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;This was fixed in a different way: &lt;a href="http://sourceforge.net/p/marathon/code/5220/#diff-2"&gt;http://sourceforge.net/p/marathon/code/5220/#diff-2&lt;/a&gt;&lt;br /&gt;
It can be closed now.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Sat, 27 Jun 2015 23:50:59 -0000</pubDate><guid isPermaLink="false">https://sourceforge.neta25acbf4c37f41473a8ce6b70136cb1e1b76878d</guid></item><item><title>#31 Fixing some GCC compiler warnings</title><link>https://sourceforge.net/p/marathon/patches/31/?limit=25#dfab</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;I've eliminated all -Wunused-variable and -Wunused-but-set-variable warnings and everything works fine for me.&lt;br /&gt;
These are the compiler flags I set in configure.ac:&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;AS_IF([test "x&lt;span class="nv"&gt;$CFLAGS&lt;/span&gt;" = "x"], [CFLAGS="-g -O2"])
AS_IF([test "x&lt;span class="nv"&gt;$CXXFLAGS&lt;/span&gt;" = "x"], [CXXFLAGS="-g -O2"])
CXXFLAGS="-Wall -Wno-sign-compare -Wno-maybe-uninitialized -Wno-narrowing -Wno-reorder -fno-strict-aliasing &lt;span class="cp"&gt;${&lt;/span&gt;&lt;span class="n"&gt;CXXFLAGS&lt;/span&gt;&lt;span class="cp"&gt;}&lt;/span&gt;"
CFLAGS="-Wall -Wno-sign-compare -Wno-maybe-uninitialized &lt;span class="cp"&gt;${&lt;/span&gt;&lt;span class="n"&gt;CFLAGS&lt;/span&gt;&lt;span class="cp"&gt;}&lt;/span&gt;"
&lt;/pre&gt;&lt;/div&gt;
&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Fri, 24 Apr 2015 17:20:13 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net64466b0c0f3f90e58af0471602e71238b87c7beb</guid></item><item><title>#31 Fixing some GCC compiler warnings</title><link>https://sourceforge.net/p/marathon/patches/31/?limit=25#9aeb</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;Some of the above changes are causing problems for me (probably the maybe-uninitialized stuff). Safe changes that don't break anything are attached as patches.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Wed, 22 Apr 2015 10:13:13 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net304c47524ee3a29f767a0f63aae1ddeb4e26765f</guid></item><item><title>#29 Fix for `make distclean' not working properly</title><link>https://sourceforge.net/p/marathon/patches/29/?limit=25#be97</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;I think I have a better solution then moving DefaultStringSets.cpp. Just add the custom target &lt;em&gt;Misc/.deps/DefaultStringSets.Po:&lt;/em&gt; to &lt;em&gt;Source_Files/Makefile.am&lt;/em&gt; and &lt;em&gt;make distclean&lt;/em&gt; won't fail anymore.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Mon, 20 Apr 2015 17:25:02 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net65f2c92363bc1b3fc61533ca109369e3c431d6d3</guid></item><item><title>Fixing some GCC compiler warnings</title><link>https://sourceforge.net/p/marathon/patches/31/</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;I've tried to get rid of some warnings that appeared when building with gcc and "-O2 -Wall".&lt;br /&gt;
maybe you can use some of that. Not sure if you like all of it though.&lt;/p&gt;
&lt;p&gt;-Warray-bounds:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/9267bb7c1efe6d3868bbeed4b0a68c84ba947188" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/9267bb7c1efe6d3868bbeed4b0a68c84ba947188&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wsequence-point:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/295c26b52584d5348e06f46f6acceeb532c25039" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/295c26b52584d5348e06f46f6acceeb532c25039&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wnarrowing:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/24ed5cfac81b13602eadcb7d46bc0d691c79d547" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/24ed5cfac81b13602eadcb7d46bc0d691c79d547&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wswitch:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/fb25db2d0b367427774a164dd3fb28d466de2447" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/fb25db2d0b367427774a164dd3fb28d466de2447&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wmaybe-uninitialized:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/9f5f82bafb46b4e533b7532bb398aefac02e8014" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/9f5f82bafb46b4e533b7532bb398aefac02e8014&lt;/a&gt;&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/f48480273f84efc2ae0ccfb36da9f1a612d8530e" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/f48480273f84efc2ae0ccfb36da9f1a612d8530e&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wunused-*:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/fea42e5f9df095654b0f50d72bac3b12c2857a03" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/fea42e5f9df095654b0f50d72bac3b12c2857a03&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;-Wparenthesis:&lt;br /&gt;
&lt;a href="https://github.com/darealshinji/aleph-one/commit/3dc7550732b29f074c27e50d58a01e004be763f8" rel="nofollow"&gt;https://github.com/darealshinji/aleph-one/commit/3dc7550732b29f074c27e50d58a01e004be763f8&lt;/a&gt;&lt;/p&gt;
&lt;p&gt;I've stopped -Wstrict-aliasing warnings by disabling strict-aliasing optimisations:&lt;br /&gt;
-fno-strict-aliasing&lt;/p&gt;
&lt;p&gt;I've disable -Wsign-compare and -Wreorder warnings.&lt;/p&gt;
&lt;p&gt;The remainging warnings are -Wdelete-non-virtual-dtor:&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;In&lt;/span&gt; &lt;span class="kd"&gt;function&lt;/span&gt; &lt;span class="s1"&gt;'sdl_font_info* load_sdl_font(const TextSpec&amp;amp;)'&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;
&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;230&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;12&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;warning&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;deleting&lt;/span&gt; &lt;span class="nx"&gt;object&lt;/span&gt; &lt;span class="nx"&gt;of&lt;/span&gt; &lt;span class="nx"&gt;polymorphic&lt;/span&gt; &lt;span class="kr"&gt;class&lt;/span&gt; &lt;span class="nx"&gt;type&lt;/span&gt; &lt;span class="s1"&gt;'sdl_font_info'&lt;/span&gt; &lt;span class="nx"&gt;which&lt;/span&gt; &lt;span class="nx"&gt;has&lt;/span&gt; &lt;span class="nx"&gt;non&lt;/span&gt;&lt;span class="o"&gt;-&lt;/span&gt;&lt;span class="nx"&gt;virtual&lt;/span&gt; &lt;span class="nx"&gt;destructor&lt;/span&gt; &lt;span class="nx"&gt;might&lt;/span&gt; &lt;span class="nx"&gt;cause&lt;/span&gt; &lt;span class="kc"&gt;undefined&lt;/span&gt; &lt;span class="nx"&gt;behaviour&lt;/span&gt; &lt;span class="cp"&gt;[&lt;/span&gt;&lt;span class="na"&gt;-Wdelete-non-virtual-dtor&lt;/span&gt;&lt;span class="cp"&gt;]&lt;/span&gt;
  &lt;span class="k"&gt;delete&lt;/span&gt; &lt;span class="nx"&gt;info&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt;
         &lt;span class="o"&gt;^&lt;/span&gt;
&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;In&lt;/span&gt; &lt;span class="nx"&gt;member&lt;/span&gt; &lt;span class="kd"&gt;function&lt;/span&gt; &lt;span class="s1"&gt;'virtual void sdl_font_info::_unload()'&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;
&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;443&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;12&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;warning&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;deleting&lt;/span&gt; &lt;span class="nx"&gt;object&lt;/span&gt; &lt;span class="nx"&gt;of&lt;/span&gt; &lt;span class="nx"&gt;polymorphic&lt;/span&gt; &lt;span class="kr"&gt;class&lt;/span&gt; &lt;span class="nx"&gt;type&lt;/span&gt; &lt;span class="s1"&gt;'sdl_font_info'&lt;/span&gt; &lt;span class="nx"&gt;which&lt;/span&gt; &lt;span class="nx"&gt;has&lt;/span&gt; &lt;span class="nx"&gt;non&lt;/span&gt;&lt;span class="o"&gt;-&lt;/span&gt;&lt;span class="nx"&gt;virtual&lt;/span&gt; &lt;span class="nx"&gt;destructor&lt;/span&gt; &lt;span class="nx"&gt;might&lt;/span&gt; &lt;span class="nx"&gt;cause&lt;/span&gt; &lt;span class="kc"&gt;undefined&lt;/span&gt; &lt;span class="nx"&gt;behaviour&lt;/span&gt; &lt;span class="cp"&gt;[&lt;/span&gt;&lt;span class="na"&gt;-Wdelete-non-virtual-dtor&lt;/span&gt;&lt;span class="cp"&gt;]&lt;/span&gt;
  &lt;span class="k"&gt;delete&lt;/span&gt; &lt;span class="k"&gt;this&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt; &lt;span class="c1"&gt;// !&lt;/span&gt;
         &lt;span class="o"&gt;^&lt;/span&gt;
&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;In&lt;/span&gt; &lt;span class="nx"&gt;member&lt;/span&gt; &lt;span class="kd"&gt;function&lt;/span&gt; &lt;span class="s1"&gt;'virtual void ttf_font_info::_unload()'&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;
&lt;span class="nx"&gt;sdl_fonts&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="nx"&gt;cpp&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;471&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="mi"&gt;9&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;warning&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt; &lt;span class="nx"&gt;deleting&lt;/span&gt; &lt;span class="nx"&gt;object&lt;/span&gt; &lt;span class="nx"&gt;of&lt;/span&gt; &lt;span class="nx"&gt;polymorphic&lt;/span&gt; &lt;span class="kr"&gt;class&lt;/span&gt; &lt;span class="nx"&gt;type&lt;/span&gt; &lt;span class="s1"&gt;'ttf_font_info'&lt;/span&gt; &lt;span class="nx"&gt;which&lt;/span&gt; &lt;span class="nx"&gt;has&lt;/span&gt; &lt;span class="nx"&gt;non&lt;/span&gt;&lt;span class="o"&gt;-&lt;/span&gt;&lt;span class="nx"&gt;virtual&lt;/span&gt; &lt;span class="nx"&gt;destructor&lt;/span&gt; &lt;span class="nx"&gt;might&lt;/span&gt; &lt;span class="nx"&gt;cause&lt;/span&gt; &lt;span class="kc"&gt;undefined&lt;/span&gt; &lt;span class="nx"&gt;behaviour&lt;/span&gt; &lt;span class="cp"&gt;[&lt;/span&gt;&lt;span class="na"&gt;-Wdelete-non-virtual-dtor&lt;/span&gt;&lt;span class="cp"&gt;]&lt;/span&gt;
  &lt;span class="k"&gt;delete&lt;/span&gt; &lt;span class="k"&gt;this&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt;
         &lt;span class="o"&gt;^&lt;/span&gt;
&lt;/pre&gt;&lt;/div&gt;
&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Mon, 20 Apr 2015 16:54:34 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net923c056dc45d0c43496821cb14c5901e3670a6bd</guid></item><item><title>#29 Fix for `make distclean' not working properly</title><link>https://sourceforge.net/p/marathon/patches/29/?limit=25#e606</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;It's listed in the top directory because if built as a module, the constructors for the static objects that create the default sets of strings are optimized out. So it has to be built in the main executable.&lt;/p&gt;
&lt;p&gt;There are more straightforward ways to build those string sets, so once that is done, it can be moved back into Misc.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Gregory Smith</dc:creator><pubDate>Mon, 20 Apr 2015 16:00:07 -0000</pubDate><guid isPermaLink="false">https://sourceforge.nete42d0555fd0f1b56b8a0c60d8b44ad011d3d237f</guid></item><item><title>#29 Fix for `make distclean' not working properly</title><link>https://sourceforge.net/p/marathon/patches/29/?limit=25#1391</link><description>&lt;div class="markdown_content"&gt;&lt;p&gt;Is there a reason why this file is in &lt;em&gt;Source_Files/Misc&lt;/em&gt;? It's listed among the &lt;em&gt;alephone_SOURCES&lt;/em&gt; in &lt;em&gt;Source_Files/Makefile.am&lt;/em&gt; but it's not listed in &lt;em&gt;Source_Files/Misc/Makefile.am&lt;/em&gt; which is why I assumed it belongs to the top level directory.&lt;/p&gt;&lt;/div&gt;</description><dc:creator xmlns:dc="http://purl.org/dc/elements/1.1/">Marshall</dc:creator><pubDate>Mon, 20 Apr 2015 15:33:27 -0000</pubDate><guid isPermaLink="false">https://sourceforge.net32ab11134c005ebc776300eb0bae5339a33ab541</guid></item></channel></rss>