<?xml version="1.0" encoding="utf-8"?>
<feed xml:lang="en" xmlns="http://www.w3.org/2005/Atom"><title>Recent posts to Discussion</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/" rel="alternate"/><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/feed.atom" rel="self"/><id>https://sourceforge.net/p/musiclibraryplayer/discussion/</id><updated>2024-01-21T15:47:24.626000Z</updated><subtitle>Recent posts to Discussion</subtitle><entry><title>Album art not displaying  - fix</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/a22f704ac9/?limit=25#c089" rel="alternate"/><published>2024-01-21T15:47:24.626000Z</published><updated>2024-01-21T15:47:24.626000Z</updated><author><name>James Moats</name><uri>https://sourceforge.net/u/thejamesmachine/</uri></author><id>https://sourceforge.netc5c6daeacd86bf8bb1e6508b4993dd8f591591ec</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;I have had some other minor changes in progress in my local copy for years and took this as an opportunity to wrap them up in a new release. I have incorporated a case insensitive image file search. Someone else had asked for PNGs to be supported as well. It now checks for folder.jpg, cover.jpg, &lt;span&gt;[track name]&lt;/span&gt;.jpg, then those files again as PNGs, then if still not found, does a loop through looking for them again as case insensitive.&lt;/p&gt;
&lt;p&gt;I don't normally have the album art option enabled, because I usually remove any non-music files from the directory when uploading. I searched and there were a few that snuck through as Folder.jpg, folder.jpg, and folder.JPG as well as some Cover.jpg and cover.jpg. My files are hosted on a NAS which is mounted on a Ubuntu server. In testing, the existing code was functioning case insensitive for me, but I verified the new approach works as well.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Album art not displaying  - fix</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/a22f704ac9/?limit=25#65cd" rel="alternate"/><published>2024-01-21T08:52:27.996000Z</published><updated>2024-01-21T08:52:27.996000Z</updated><author><name>Rik Sprint</name><uri>https://sourceforge.net/u/sugacoma/</uri></author><id>https://sourceforge.netc2526ecad80edb7d2e1d51054964408ca2f678fb</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;most likely cause is your running the script on a unix server rather than windows. which means you may need to change a couple of lines&lt;/p&gt;
&lt;p&gt;functions.php (2 hits)&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span&gt;&lt;/span&gt;&lt;code&gt;&lt;span class="w"&gt;    &lt;/span&gt;&lt;span class="nt"&gt;Line&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;1152&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="w"&gt;  &lt;/span&gt;&lt;span class="nt"&gt;elseif&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;(&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;file_exists&lt;/span&gt;&lt;span class="o"&gt;($&lt;/span&gt;&lt;span class="nt"&gt;path&lt;/span&gt;&lt;span class="o"&gt;.&lt;/span&gt;&lt;span class="s1"&gt;'folder.jpg'&lt;/span&gt;&lt;span class="o"&gt;)&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;)&lt;/span&gt;
&lt;span class="w"&gt;    &lt;/span&gt;&lt;span class="nt"&gt;Line&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;1154&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="w"&gt;      &lt;/span&gt;&lt;span class="o"&gt;$&lt;/span&gt;&lt;span class="nt"&gt;linkPath&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;=&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;rawurlencode&lt;/span&gt;&lt;span class="o"&gt;($&lt;/span&gt;&lt;span class="nt"&gt;path&lt;/span&gt;&lt;span class="o"&gt;.&lt;/span&gt;&lt;span class="s1"&gt;'folder.jpg'&lt;/span&gt;&lt;span class="o"&gt;);&lt;/span&gt;
&lt;/code&gt;&lt;/pre&gt;&lt;/div&gt;

&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span&gt;&lt;/span&gt;&lt;code&gt;change to

functions.php (2 hits)
&lt;/code&gt;&lt;/pre&gt;&lt;/div&gt;

&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span&gt;&lt;/span&gt;&lt;code&gt;&lt;span class="nt"&gt;Line&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;1152&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="w"&gt;  &lt;/span&gt;&lt;span class="nt"&gt;elseif&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;(&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;file_exists&lt;/span&gt;&lt;span class="o"&gt;($&lt;/span&gt;&lt;span class="nt"&gt;path&lt;/span&gt;&lt;span class="o"&gt;.&lt;/span&gt;&lt;span class="s1"&gt;'Folder.jpg'&lt;/span&gt;&lt;span class="o"&gt;)&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;)&lt;/span&gt;
&lt;span class="nt"&gt;Line&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;1154&lt;/span&gt;&lt;span class="o"&gt;:&lt;/span&gt;&lt;span class="w"&gt;      &lt;/span&gt;&lt;span class="o"&gt;$&lt;/span&gt;&lt;span class="nt"&gt;linkPath&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="o"&gt;=&lt;/span&gt;&lt;span class="w"&gt; &lt;/span&gt;&lt;span class="nt"&gt;rawurlencode&lt;/span&gt;&lt;span class="o"&gt;($&lt;/span&gt;&lt;span class="nt"&gt;path&lt;/span&gt;&lt;span class="o"&gt;.&lt;/span&gt;&lt;span class="s1"&gt;'Folder.jpg'&lt;/span&gt;&lt;span class="o"&gt;);&lt;/span&gt;
&lt;/code&gt;&lt;/pre&gt;&lt;/div&gt;

&lt;p&gt;capital "F" in folder is important on unix systems&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Should there be a warning about / measures against directory crawling?</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/c9f8c28c06/?limit=25#2346" rel="alternate"/><published>2020-05-18T03:07:21.938000Z</published><updated>2020-05-18T03:07:21.938000Z</updated><author><name>James Moats</name><uri>https://sourceforge.net/u/thejamesmachine/</uri></author><id>https://sourceforge.netcc26e8bf9f99dcd02e91b6947d3efacee6d1ad37</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;New release 2.0.2 fixes this issue. It doesn't allow access below the specified root directory and also doesn't show directories that don't eventually lead to playable tracks. Thanks for reporting this!&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Should there be a warning about / measures against directory crawling?</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/c9f8c28c06/?limit=25#29a4" rel="alternate"/><published>2020-04-27T15:09:53.178000Z</published><updated>2020-04-27T15:09:53.178000Z</updated><author><name>James Moats</name><uri>https://sourceforge.net/u/thejamesmachine/</uri></author><id>https://sourceforge.net67e38857d1ca3854550ce0b3ac561bdbf8d3b072</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;I see what you're saying now. Previously, it would only show directories that contained playable music files. It looks like that was inadvertently changed in the 2.0 redesign. I have written up a ticket, because the way it is currently working is not ideal. Thanks for taking the time to clarify.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Should there be a warning about / measures against directory crawling?</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/c9f8c28c06/?limit=25#f218" rel="alternate"/><published>2020-04-26T04:21:02.596000Z</published><updated>2020-04-26T04:21:02.596000Z</updated><author><name>Uwe Scholz</name><uri>https://sourceforge.net/u/oosho3/</uri></author><id>https://sourceforge.net1c234de41a724830c5c37ef93df85a8df5cc3b18</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;Thank you for you reply. And thanks for MLP. I love straightforward look, and implementation.&lt;/p&gt;
&lt;p&gt;The password protection advise is indeed wise, and appearently I just overlooked/ignored it.&lt;/p&gt;
&lt;p&gt;Still, many might remain unanware that it is possible to look into any folder inside the webroot using ?dir=../../../ parameters. &lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Should there be a warning about / measures against directory crawling?</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/c9f8c28c06/?limit=25#c968" rel="alternate"/><published>2020-04-26T02:28:35.454000Z</published><updated>2020-04-26T02:28:35.454000Z</updated><author><name>James Moats</name><uri>https://sourceforge.net/u/thejamesmachine/</uri></author><id>https://sourceforge.net9c46498da34b01a936d63cc493960f983d6abcb6</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;I apologize about the delay, I didn't see notification of your post.&lt;/p&gt;
&lt;p&gt;From the ReadMe.txt: &lt;br/&gt;
"It is advised that you password protect the Music Library &amp;amp; Player directory using htaccess or other method to restrict public access. "&lt;/p&gt;
&lt;p&gt;Aside from that, it is advised to add a Robots.txt file to your website root directory, denying access to any directories that you don't want indexed by search engines. That really isn't related to this script, it's general "having a website" type info.&lt;/p&gt;
&lt;p&gt;&lt;a href="https://support.google.com/webmasters/answer/6062608?hl=en" rel="nofollow"&gt;https://support.google.com/webmasters/answer/6062608?hl=en&lt;/a&gt;&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Should there be a warning about / measures against directory crawling?</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/c9f8c28c06/?limit=25#513f" rel="alternate"/><published>2020-03-23T13:49:19.198000Z</published><updated>2020-03-23T13:49:19.198000Z</updated><author><name>Uwe Scholz</name><uri>https://sourceforge.net/u/oosho3/</uri></author><id>https://sourceforge.net5d7af90f4b5a5d4cbd13bf442d71a22e1e74651c</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;When using MLP on a public webserver, it is easy to crawl folders in the webroot, including folders which were never intended to be visible to the public. For this, anyone can call setup.php, or use the “dir“ URI string parameter. Perhaps not everybody feels comfortable with that. Many are probably not aware of this.&lt;/p&gt;
&lt;p&gt;Some measures against it could be:&lt;br/&gt;
- Password protect the folder where index.php resides&lt;br/&gt;
- Delete setup.php from webserver, after configuration is done&lt;br/&gt;
- Remove setup menu code from index.php&lt;br/&gt;
- Add code to avoid crawling via ?dir=../../../ strings and others&lt;/p&gt;
&lt;p&gt;However, should there be a warning, or some default measures to avoid this unwanted side effect?&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>To user "S Vestal - Scootr1975"</title><link href="https://sourceforge.net/p/musiclibraryplayer/discussion/general/thread/54cabade/?limit=25#f8e6" rel="alternate"/><published>2017-01-15T16:40:30.127000Z</published><updated>2017-01-15T16:40:30.127000Z</updated><author><name>James Moats</name><uri>https://sourceforge.net/u/thejamesmachine/</uri></author><id>https://sourceforge.net525fcff5db9f3698aef219458c62eabb18372e7f</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;You sent an e-mail through the blind e-mail form here, but set up your profile in such a way that it is not possible to reply to your message. &lt;/p&gt;
&lt;p&gt;Send an actual e-mail to me at jhmoats@willowlakestudio.com or update your profile to allow direct messaging. Let me know one way or the other how to get back in touch and I will try and help you with the customization you were asking about.&lt;/p&gt;
&lt;p&gt;Thanks,&lt;br/&gt;
James&lt;/p&gt;&lt;/div&gt;</summary></entry></feed>