<?xml version="1.0" encoding="utf-8"?>
<feed xml:lang="en" xmlns="http://www.w3.org/2005/Atom"><title>Recent changes to bugs</title><link href="https://sourceforge.net/p/ovaldi/bugs/" rel="alternate"/><link href="https://sourceforge.net/p/ovaldi/bugs/feed.atom" rel="self"/><id>https://sourceforge.net/p/ovaldi/bugs/</id><updated>2016-01-14T18:15:04.285000Z</updated><subtitle>Recent changes to bugs</subtitle><entry><title>null characters may be collected as part of reg_expand_sz registry items</title><link href="https://sourceforge.net/p/ovaldi/bugs/281/" rel="alternate"/><published>2016-01-14T18:15:04.285000Z</published><updated>2016-01-14T18:15:04.285000Z</updated><author><name>Brady Alleman</name><uri>https://sourceforge.net/u/balleman/</uri></author><id>https://sourceforge.net14a0a75d6af0d90dc91781ad83d25b87d645da71</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;I've encountered a problem with collecting a file object that has its path specified using a variable defined by collecting a reg_expand_sz registry value.  If the type of the value is reg_sz with the same content, as set with regedit, the collection succeeds.  In examining RegistryProbe.cpp, it appears that there is code to remove trailing nulls for the reg_sz type, which is absent for the reg_expand_sz type.  My guess is that adding this same protection to the reg_expand_sz handling will resolve the issue, but I've not tried this.  A workaround that seems to be successful is to use a regex_capture with pattern of &lt;code&gt;(.*)&lt;/code&gt; in the variable, which allows the file object to collect successfully.  Example definitions illustrating these behaviors with results from OVALdi and Policy Auditor are attached.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>#280 fileeffectiverights53 - generic_all not collected correctly</title><link href="https://sourceforge.net/p/ovaldi/bugs/280/?limit=25#123c" rel="alternate"/><published>2015-09-21T18:47:06.720000Z</published><updated>2015-09-21T18:47:06.720000Z</updated><author><name>Michael Chisholm</name><uri>https://sourceforge.net/u/chishomi/</uri></author><id>https://sourceforge.net6a7ddfa2380b188b38aca648668cf94482681981</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;ul&gt;
&lt;li&gt;&lt;strong&gt;status&lt;/strong&gt;: open --&amp;gt; closed-fixed&lt;/li&gt;
&lt;li&gt;&lt;strong&gt;assigned_to&lt;/strong&gt;: Michael Chisholm&lt;/li&gt;
&lt;/ul&gt;&lt;/div&gt;</summary></entry><entry><title>#280 fileeffectiverights53 - generic_all not collected correctly</title><link href="https://sourceforge.net/p/ovaldi/bugs/280/?limit=25#460b" rel="alternate"/><published>2015-09-21T17:36:38.748000Z</published><updated>2015-09-21T17:36:38.748000Z</updated><author><name>Matthew N. Wojcik</name><uri>https://sourceforge.net/u/woj-infosec/</uri></author><id>https://sourceforge.net9daf66aebc255a95fee7908fcc17dbec9f0e1585</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;I've just been running into this bug, too.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>fileeffectiverights53 - generic_all not collected correctly</title><link href="https://sourceforge.net/p/ovaldi/bugs/280/" rel="alternate"/><published>2015-09-08T17:01:26.126000Z</published><updated>2015-09-08T17:01:26.126000Z</updated><author><name>Brady Alleman</name><uri>https://sourceforge.net/u/balleman/</uri></author><id>https://sourceforge.net4a9c2cf56d0b4c5221f8f8a615f480365361384c</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;We've observed ovaldi collecting a fileeffectiverights53 generic_all entity as true in cases where it should be false.  In reviewing the source, it appears that generic_all is being set based on the same criteria as the file_read_data entity, which should not be correct.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>fileeffectiverights53 - generic_all not collected correctly</title><link href="https://sourceforge.net/p/ovaldi/bugs/280/" rel="alternate"/><published>2015-09-08T17:01:26.126000Z</published><updated>2015-09-08T17:01:26.126000Z</updated><author><name>Brady Alleman</name><uri>https://sourceforge.net/u/balleman/</uri></author><id>https://sourceforge.net74a88e96b47f9f934260ff38acd04c54c8d0ac17</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;Ticket 280 has been modified: fileeffectiverights53 - generic_all not collected correctly&lt;br/&gt;
Edited By: Michael Chisholm (chishomi)&lt;br/&gt;
Status updated: u'open' =&amp;gt; u'closed-fixed'&lt;br/&gt;
Owner updated: None =&amp;gt; u'chishomi'&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>textfilecontent54 does not collect when filepath contains intermediate links to directories</title><link href="https://sourceforge.net/p/ovaldi/bugs/279/" rel="alternate"/><published>2015-09-02T14:23:28.081000Z</published><updated>2015-09-02T14:23:28.081000Z</updated><author><name>Brady Alleman</name><uri>https://sourceforge.net/u/balleman/</uri></author><id>https://sourceforge.net7141b20a397b090a6b6d8fe1378f8a23596e2640</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;p&gt;We've identified an issue where when collecting textfilecontent54, if the filepath provided has a link as an intermediate component, the item results in a status of 'does not exist', but it should exist and be collected.&lt;/p&gt;
&lt;p&gt;An example definition, file structure, and results is attached.  On a different tool (Policy Auditor results provided), the item is collected as expected.&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>Memory leak for AbsEntity</title><link href="https://sourceforge.net/p/ovaldi/bugs/278/" rel="alternate"/><published>2015-04-02T03:31:09.410000Z</published><updated>2015-04-02T03:31:09.410000Z</updated><author><name>unicode</name><uri>https://sourceforge.net/u/unicode-forge/</uri></author><id>https://sourceforge.net11dcfed024fb7473a5b9deedef4cafbf0542aa0f</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;h2 id="memory-leak-for-absentity"&gt;Memory leak for AbsEntity&lt;/h2&gt;
&lt;p&gt;void AbsEntity::SetValue(string value) {&lt;br /&gt;
    if ( this-&amp;gt;value.empty() ){&lt;br /&gt;
        this-&amp;gt;value.push_back(new StringEntityValue(value));  //memory allocated&lt;br /&gt;
    }else{&lt;br /&gt;
        this-&amp;gt;value.front()-&amp;gt;SetValue(value);&lt;br /&gt;
    }&lt;br /&gt;
}&lt;/p&gt;
&lt;p&gt;&lt;strong&gt;Destructor does nothing, so memory leaked&lt;/strong&gt;&lt;/p&gt;
&lt;p&gt;&lt;strong&gt;Suggestion&lt;/strong&gt;:&lt;br /&gt;
(1)relase memory in Destructor&lt;br /&gt;
(2)Because of the absence of the COPY CONSTRUCTOR, the default CONSTRUCTOR will be used automatically, then the members(include 'vaule' member) will be shallow-copied. So, if a Entity Object is copied, the memory will be released multi times, error will occur.&lt;/p&gt;
&lt;p&gt;For example:&lt;/p&gt;
&lt;p&gt;StringVector&lt;em&gt; AbsFileFinder::GetPaths(ObjectEntity&lt;/em&gt; path, BehaviorVector&lt;em&gt; behaviors) {&lt;br /&gt;
    auto_ptr&amp;lt;StringVector&amp;gt; pathsFound(new StringVector());&lt;br /&gt;
    // make a copy of the path so I can switch its operation without&lt;br /&gt;
    // affecting the original.&lt;br /&gt;
    ObjectEntity tmpPath(&lt;/em&gt;path);  //default consctrutor will be called!!!&lt;br /&gt;
    ...&lt;/p&gt;
&lt;p&gt;&lt;strong&gt;Code Description as following: &lt;/strong&gt; &lt;/p&gt;
&lt;p&gt;AbsEntity::AbsEntity(AbsEntity &amp;amp;a){ &lt;br /&gt;
    this-&amp;gt;name = a.name;&lt;br /&gt;
    this-&amp;gt;value = a.value;&lt;br /&gt;
    this-&amp;gt;datatype = a.datatype;&lt;br /&gt;
    this-&amp;gt;varCheck = a.varCheck;&lt;br /&gt;
    this-&amp;gt;operation = a.operation;&lt;br /&gt;
    this-&amp;gt;varRef = a.varRef;&lt;br /&gt;
    this-&amp;gt;nil = a.nil;&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span class="n"&gt;this&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="n"&gt;shallowCopy&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="nb"&gt;true&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt; &lt;span class="c1"&gt;//Added, the member (type boolean) added as a flag&lt;/span&gt;
&lt;/pre&gt;&lt;/div&gt;
&lt;p&gt;}&lt;/p&gt;
&lt;p&gt;AbsEntity::AbsEntity(string name, string value, OvalEnum::Datatype datatype, OvalEnum::Operation operation, AbsVariable* varRef, OvalEnum::Check varCheck, bool nil) {&lt;br /&gt;
  ..&lt;br /&gt;
   this-&amp;gt;shallowCopy = false;&lt;br /&gt;
}&lt;/p&gt;
&lt;p&gt;AbsEntity::~AbsEntity(){&lt;br /&gt;
   if (!shallowCopy){&lt;br /&gt;
    //iterator the value vector, relasing the memeory&lt;br /&gt;
    ...&lt;br /&gt;
   }&lt;br /&gt;
}&lt;/p&gt;&lt;/div&gt;</summary></entry><entry><title>#277 WindowsCommon::init maybe not right?</title><link href="https://sourceforge.net/p/ovaldi/bugs/277/?limit=25#d631" rel="alternate"/><published>2015-03-12T20:43:00.454000Z</published><updated>2015-03-12T20:43:00.454000Z</updated><author><name>Michael Chisholm</name><uri>https://sourceforge.net/u/chishomi/</uri></author><id>https://sourceforge.netb7b865a56b48f7cce74a09cb9ff48be1c91a9c9a</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;ul&gt;
&lt;li&gt;&lt;strong&gt;status&lt;/strong&gt;: open --&amp;gt; closed-fixed&lt;/li&gt;
&lt;/ul&gt;&lt;/div&gt;</summary></entry><entry><title>#276 ProcessProbe::BuildProcessItem, local var 'position ' should be size_t type</title><link href="https://sourceforge.net/p/ovaldi/bugs/276/?limit=25#b1c8" rel="alternate"/><published>2015-03-12T20:42:16.474000Z</published><updated>2015-03-12T20:42:16.474000Z</updated><author><name>Michael Chisholm</name><uri>https://sourceforge.net/u/chishomi/</uri></author><id>https://sourceforge.netdeb51a243bf64b8103d0da3e4d794fcc1d3d3849</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;ul&gt;
&lt;li&gt;&lt;strong&gt;status&lt;/strong&gt;: open --&amp;gt; closed-fixed&lt;/li&gt;
&lt;/ul&gt;&lt;/div&gt;</summary></entry><entry><title>WindowsCommon::init maybe not right?</title><link href="https://sourceforge.net/p/ovaldi/bugs/277/" rel="alternate"/><published>2015-03-12T04:56:12.300000Z</published><updated>2015-03-12T04:56:12.300000Z</updated><author><name>unicode</name><uri>https://sourceforge.net/u/unicode-forge/</uri></author><id>https://sourceforge.netd7d547bf88e55789d74f03d0c702690b4b2c77ca</id><summary type="html">&lt;div class="markdown_content"&gt;&lt;h2 id="for-windowscommoncpp-windowscommaninit-function"&gt;For WindowsCommon.cpp, WindowsComman::init function:&lt;/h2&gt;
&lt;p&gt;...&lt;br /&gt;
    if (nas)&lt;br /&gt;
        throw Exception("Couldn't get domain join info: NetGetJoinInformation: " +&lt;br /&gt;
            GetErrorMessage(nas));&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;&lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;njs&lt;/span&gt; &lt;span class="o"&gt;==&lt;/span&gt; &lt;span class="n"&gt;NetSetupDomainName&lt;/span&gt;&lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;{&lt;/span&gt;
    &lt;span class="n"&gt;globals&lt;/span&gt;&lt;span class="o"&gt;::&lt;/span&gt;&lt;span class="n"&gt;domainName&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="n"&gt;joinInfo&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt;
    &lt;span class="n"&gt;NetApiBufferFree&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;joinInfo&lt;/span&gt;&lt;span class="p"&gt;);&lt;/span&gt;
&lt;span class="p"&gt;}&lt;/span&gt; &lt;span class="k"&gt;else&lt;/span&gt; &lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;njs&lt;/span&gt; &lt;span class="o"&gt;==&lt;/span&gt; &lt;span class="n"&gt;NetSetupWorkgroupName&lt;/span&gt;&lt;span class="p"&gt;)&lt;/span&gt;
    &lt;span class="c1"&gt;// don't care about workgroups!&lt;/span&gt;
    &lt;span class="n"&gt;NetApiBufferFree&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;joinInfo&lt;/span&gt;&lt;span class="p"&gt;);&lt;/span&gt;

&lt;span class="c1"&gt;// stop here if not joined to a domain.&lt;/span&gt;
&lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;njs&lt;/span&gt; &lt;span class="o"&gt;!=&lt;/span&gt; &lt;span class="n"&gt;NetSetupDomainName&lt;/span&gt;&lt;span class="p"&gt;)&lt;/span&gt;  &lt;span class="c1"&gt;//LINE 203&lt;/span&gt;
    &lt;span class="k"&gt;return&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt;

&lt;span class="c1"&gt;// Get domain SID&lt;/span&gt;
&lt;span class="n"&gt;globals&lt;/span&gt;&lt;span class="o"&gt;::&lt;/span&gt;&lt;span class="n"&gt;domainSID&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="n"&gt;GetSIDForTrusteeNameW&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;globals&lt;/span&gt;&lt;span class="o"&gt;::&lt;/span&gt;&lt;span class="n"&gt;domainName&lt;/span&gt;&lt;span class="p"&gt;);&lt;/span&gt;
&lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="o"&gt;!&lt;/span&gt;&lt;span class="n"&gt;globals&lt;/span&gt;&lt;span class="o"&gt;::&lt;/span&gt;&lt;span class="n"&gt;domainSID&lt;/span&gt;&lt;span class="p"&gt;)&lt;/span&gt;
    &lt;span class="c1"&gt;// can this actually happen?&lt;/span&gt;
    &lt;span class="n"&gt;throw&lt;/span&gt; &lt;span class="n"&gt;Exception&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="s"&gt;"Couldn't find SID for domain name: "&lt;/span&gt; &lt;span class="o"&gt;+&lt;/span&gt;
    &lt;span class="n"&gt;UnicodeToAsciiString&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;globals&lt;/span&gt;&lt;span class="o"&gt;::&lt;/span&gt;&lt;span class="n"&gt;domainName&lt;/span&gt;&lt;span class="p"&gt;));&lt;/span&gt;

&lt;span class="c1"&gt;// disable rollback, since we finished successfully&lt;/span&gt;
&lt;span class="n"&gt;errorRollback&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="n"&gt;success&lt;/span&gt;&lt;span class="p"&gt;();&lt;/span&gt;
&lt;/pre&gt;&lt;/div&gt;
&lt;p&gt;...&lt;/p&gt;
&lt;p&gt;&lt;strong&gt;&lt;em&gt;FOR LINE 203&lt;/em&gt;&lt;/strong&gt;&lt;br /&gt;
maybe, it should be:&lt;/p&gt;
&lt;div class="codehilite"&gt;&lt;pre&gt;    &lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="n"&gt;njs&lt;/span&gt; &lt;span class="o"&gt;!=&lt;/span&gt; &lt;span class="n"&gt;NetSetupDomainName&lt;/span&gt;&lt;span class="p"&gt;){&lt;/span&gt;  &lt;span class="c1"&gt;//LINE 203&lt;/span&gt;
            &lt;span class="n"&gt;errorRollback&lt;/span&gt;&lt;span class="p"&gt;.&lt;/span&gt;&lt;span class="n"&gt;success&lt;/span&gt;&lt;span class="p"&gt;();&lt;/span&gt;
    &lt;span class="k"&gt;return&lt;/span&gt;&lt;span class="p"&gt;;&lt;/span&gt;
    &lt;span class="p"&gt;}&lt;/span&gt;
&lt;/pre&gt;&lt;/div&gt;
&lt;p&gt;&lt;strong&gt;&lt;em&gt;Thought not joined in domain, but it should return with success, else, the "uninit" function should be called, and the compterSID should be released and set to NULL &lt;/em&gt;&lt;/strong&gt;*&lt;/p&gt;&lt;/div&gt;</summary></entry></feed>