Recent changes to bugs

Notice in saja.php

Anonymous — Tue, 04 Sep 2007 14:09:31 -0000

The are two more notice at 229 and 230

It is not always true that there are action and property.

list($target, $action) = $this->texplode(',', $target);
list($targetId, $targetProperty) = $this->texplode(':', $target);

It is sufficient to correct as follow:
@list($target, $action) = $this->texplode(',', $target);
@list($targetId, $targetProperty) = $this->texplode(':', $target);

Missing index HISTORY in $REQ

Anonymous — Tue, 04 Sep 2007 13:54:37 -0000

In saja.process.php there is the following at line 42:

$use_history = $REQ['HISTORY'];

which generate a notice due to undefine index.

I looked at the code and nowere such index is created, I guess it should be around line 230 in saja.php where the $_SESSION is valorized.

saja.js: getForm()-implementation not correct

Tim Boven — Tue, 28 Aug 2007 10:31:31 -0000

While using the getForm()-function (in saja.js) I noticed an incorrect behaviour when used with a checkbox.
When I looked at the implemenation I saw that there is also a similar problem with radio-buttons and select-items.

I updated the implementation to work with checkboxes, I'll also include the code to work with the other elements and post an update of the code later.

Updated code to work with checkboxes:

getForm: function(f){
var vals = {};
for(var i=0; i<f.length; i++)
if(f[i].id) {
if (f[i].type) {
var type = f[i].type.toLowerCase()
if (type == "checkbox") {
if (f[i].checked)
vals[f[i].id] = f[i].value;
else vals[f[i].id] = '';
}
else vals[f[i].id] = f[i].value;
//FIXME: Also for radio & select
}
else {
vals[f[i].id] = f[i].value;
}
}
return vals;
}

Wrong class variable access in saja.php

Alex — Mon, 10 Apr 2006 14:23:50 -0000

In function sajasplit you have:

function sajasplit()
{
if(!$this->$splitsent)
{
$this->$splitsent = 1;
return '<saja_split>';
}
}

Should be:

function sajasplit()
{
if(!$this->splitsent)
{
$this->splitsent = 1;
return '<saja_split>';
}
}