Recent changes to bugs

#16 sgcommon.c & sgsubmon.c should include sys/sysmacros.h

Andy Cress — Mon, 11 Dec 2017 16:41:13 -0000

status: accepted --> closed-fixed

#16 sgcommon.c & sgsubmon.c should include sys/sysmacros.h

Andy Cress — Mon, 11 Dec 2017 16:40:54 -0000

Fix released with scsirastools-1.6.6 around 04/22/2016.

#17 please rename configure.in to configure.ac

Andy Cress — Mon, 11 Dec 2017 16:40:16 -0000

status: accepted --> closed-fixed

#17 please rename configure.in to configure.ac

Andy Cress — Mon, 11 Dec 2017 16:39:30 -0000

Fix released with scsirastools-1.6.6 around 04/22/2016.

#16 sgcommon.c & sgsubmon.c should include sys/sysmacros.h

Andy Cress — Thu, 21 Apr 2016 14:06:42 -0000

status: unread --> accepted
assigned_to: Andy Cress

#17 please rename configure.in to configure.ac

Andy Cress — Thu, 21 Apr 2016 14:05:52 -0000

status: unread --> accepted
assigned_to: Andy Cress

please rename configure.in to configure.ac

Mike Frysinger — Thu, 21 Apr 2016 05:04:04 -0000

the configure.in name has been deprecated by the autotools guys for a while now, and newer versions are starting to make usage of it fatal. please rename it to configure.ac to match upstream's recommendations.

please rename configure.in to configure.ac

Mike Frysinger — Thu, 21 Apr 2016 05:04:04 -0000

Ticket 17 has been modified: please rename configure.in to configure.ac
Edited By: Andy Cress (arcress)
Status updated: u'unread' => u'accepted'
Owner updated: None => u'arcress'

please rename configure.in to configure.ac

Mike Frysinger — Thu, 21 Apr 2016 05:04:04 -0000

Ticket 17 has been modified: please rename configure.in to configure.ac
Edited By: Andy Cress (arcress)
Status updated: u'accepted' => u'closed-fixed'

sgcommon.c & sgsubmon.c should include sys/sysmacros.h

Mike Frysinger — Thu, 21 Apr 2016 04:58:33 -0000

the major/minor funcs are defined in sys/sysmacros.h, so these files should include it explicitly. otherwise build fails w/newer C libs which are dropping the implicit include via sys/types.h (like glibc).

--- a/src/sgcommon.c
+++ b/src/sgcommon.c
@@ -62,6 +62,7 @@
   -------------------------------------------------------------------------*/
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
--- a/src/sgsubmon.c
+++ b/src/sgsubmon.c
@@ -34,6 +34,7 @@
  *---------------------------------------------------------------------------*/
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>