Recent changes to bugs

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Ike To — Fri, 31 Mar 2017 08:18:26 -0000

I think this is not completely resolved. When compiling Pantheios with GCC 4.8 I now have a lot fewer warnings, but still some are there, like this:

In file included from /home/builder/include/stlsoft/string/simple_string.hpp:106:0,
                 from /home/builder/include/stlsoft/string/view_slice_functions.hpp:91,
                 from ../../src/util/be.parse.cpp:51:
/home/builder/include/stlsoft/conversion/sap_cast.hpp: In function 'TO stlsoft::sap_cast(FROM)':
/home/builder/include/stlsoft/conversion/sap_cast.hpp:145:69: warning: typedef 'from_base_type' locally defined but not used [-Wunused-local-typedefs]
     typedef ss_typename_type_k base_type_traits<FROM>::base_type    from_base_type;
                                                                     ^
/home/builder/include/stlsoft/conversion/sap_cast.hpp:146:69: warning: typedef 'to_base_type' locally defined but not used [-Wunused-local-typedefs]
     typedef ss_typename_type_k base_type_traits<TO>::base_type      to_base_type;

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Mikko Koivunalho — Sun, 14 Feb 2016 13:38:22 -0000

This is fixed in the version 1.9.125.

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Mikko Koivunalho — Sat, 09 Jan 2016 06:46:40 -0000

Hi, Ludvik.

Can you send me the file be.parse.cpp (or a stripped down version of it)? I want to try to reproduce the error.

which compiler version you are using?

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Mikko Koivunalho — Sat, 09 Jan 2016 06:46:08 -0000

Hi, Ludvik.

Can you send me the file be.parse.cpp (or a stripped down version of it)? I want to try to reproduce the error.

which compiler version you are using?

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Ludvik Jerabek — Fri, 08 Jan 2016 19:40:29 -0000

Looks like this issue is related. I applied the patched version of slysoft.h however make throws the following error:

Ensuring all STLSoft C source files are in UNIX format
g++ -c -Wall -pedantic -Wno-long-long -Wno-unused-value -Wno-unused-function -Wno-array-bounds -Werror -D_REENTRANT -D_DEBUG -UNDEBUG -Dunix -DSHWILD_QUALITY_NO_USE_XCOVER -DPANTHEIOS_NO_AUTO_INIT -I../../include -I"/home/ludio/Desktop/stlsoft-1.9.124/include" -o util.be_parse.mt.debug.o ../../src/util/be.parse.cpp
In file included from /home/ludio/Desktop/stlsoft-1.9.124/include/stlsoft/string/simple_string.hpp:106:0,
from /home/ludio/Desktop/stlsoft-1.9.124/include/stlsoft/string/view_slice_functions.hpp:91,
from ../../src/util/be.parse.cpp:51:
/home/ludio/Desktop/stlsoft-1.9.124/include/stlsoft/conversion/sap_cast.hpp: In function ‘TO stlsoft::sap_cast(FROM)’:
/home/ludio/Desktop/stlsoft-1.9.124/include/stlsoft/conversion/sap_cast.hpp:145:69: error: typedef ‘from_base_type’ locally defined but not used [-Werror=unused-local-typedefs]
typedef ss_typename_type_k base_type_traits<FROM>::base_type from_base_type;
^
/home/ludio/Desktop/stlsoft-1.9.124/include/stlsoft/conversion/sap_cast.hpp:146:69: error: typedef ‘to_base_type’ locally defined but not used [-Werror=unused-local-typedefs]
typedef ss_typename_type_k base_type_traits<TO>::base_type to_base_type;
^
cc1plus: all warnings being treated as errors
make: *** [util.be_parse.mt.debug.o] Error 1

#61 GNU CC 4.8 compatibility: unused-local-typedefs

Mikko Koivunalho — Mon, 28 Dec 2015 09:48:54 -0000

I have created a pull request to fix this: https://github.com/synesissoftware/STLSoft-1.9/pull/2

-# define STLSOFT_STATIC_ASSERT(expr) do { typedef int ai[(expr) ? 1 : -1]; } while(0)
+# if defined(STLSOFT_COMPILER_IS_GCC) && GNUC >= 4 && GNUC_MINOR >= 8
+# define STLSOFT_STATIC_ASSERT(expr) do { typedef int ai[(expr) ? 1 : -1] attribute((unused)); } while(0)
+# else / Compiler is Gnu 4.8 or newer with -Wunused-local-typedefs included in -Wall. /
+# define STLSOFT_STATIC_ASSERT(expr) do { typedef int ai[(expr) ? 1 : -1]; } while(0)
+# endif / Compiler is Gnu 4.8 or newer with -Wunused-local-typedefs included in -Wall. /

#64 auto_buffer <...>::swap performance

Matt Wilson — Thu, 27 Aug 2015 20:56:35 -0000

You're most welcome.

I'd be interested to hear what you're using STLSoft for.

#58 winstl::process_sequence can't use in unicode vsproject

Matt Wilson — Wed, 26 Aug 2015 08:08:12 -0000

(Apologies for taking so long to respond.)

This is confirmed, and fixed. Will be in next release (1.9.120), which should be next day or so.

Matt

#64 auto_buffer <...>::swap performance

Matt Wilson — Wed, 26 Aug 2015 07:33:35 -0000

Just verified that this does indeed bring a performance bump - on the order of 20% in the scenarios I tested.

Just got to do functional testing now, then it's in next release.

Thanks

Matt

#63 auto_buffer <...>::empty (Documentation Note)

Matt Wilson — Wed, 26 Aug 2015 06:46:06 -0000

Was a flat-out error - a vestige from an earlier time when the user was not allowed to pass 0 to the ctor. Will be included in next release.

Thanks! :-)