Repository navigation
Fields: Prevent animation on item removal for MediaEdit - #85372
Merged
ciampo merged 3 commits intoOct 22, 2026
Merged
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Updated as activity occurs, without notifying anyone named here. Add the |
yashjawale
marked this pull request as ready for review
October 22, 2026 07:01
ciampo
self-requested a review
October 22, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #83854
Carries over changes from #84940
This PR prevents animation of item removal so that any items below MediaEdit don't overlap it while it animates to the reduced height.
Why?
Removing the first item from a compact multiple selection makes the remaining rows animate outside the shrinking group and briefly overlap any items below the component. Leading to a degrated user experience.
How?
This PR updates animation logic so that it is only applied when same attachment IDs change order.
When items are added or removed, the running movement animations are cancelled and the rows are placed directly in their new positions. Membership changes are checked even when a surviving row's index stays unchanged.
Testing Instructions
We can test this by temporarily applying this patch to allow multiple selection in Site Editor's Identity section for "Site logo" input.
Patch
/wp-admin/site-editor.php?p=%2FidentityScreenshots or screencast
Screen.Recording.2026-10-22.at.11.58.43.AM.mov
Screen.Recording.2026-10-22.at.12.14.56.PM.mov
Use of AI Tools
None