mon-devel Mailing List for mon

On Thu, Jul 21, 2005 at 07:50:19PM -0700, Konstantin 'Kastus' Shchuka wrote:
> I had to make the following changes to make snpp.alert work:
> 
> --- cvsroot/mon/alert.d/snpp.alert      2004-06-08 22:18:07.000000000 -0700
> +++ cvsroot-mine/mon/alert.d/snpp.alert 2005-07-21 19:15:31.000000000 -0700
> @@ -25,7 +25,7 @@
>  # $Id: snpp.alert,v 1.1.1.1 2004/06/09 05:18:07 trockij Exp $
>  #
>  use strict;
> -use vars qw /$opt_g $opt_q $opt_s $opt_t/;
> +use vars qw /$opt_g $opt_q $opt_s $opt_t $opt_h $opt_l $opt_u/;
>  use Getopt::Std;
>  use Net::SNPP;
>  
> @@ -52,7 +52,7 @@
>  
>  my $snpp = Net::SNPP->new ($opt_q) or die;
>  
> -$ALERT = $opt_u ? "UPALERT" : "ALERT";
> +my $ALERT = $opt_u ? "UPALERT" : "ALERT";
>  
>  $snpp->send ( Pager => [ @ARGV ], Message => "$ALERT $opt_g/$opt_s: $summary ($wday $mon $day $tm)" );


Yeah, me too.  I guess not too many people were using it.

Here's my version, which adds a few more of the features that are
supposed to be in all monitor scripts:


@@ -47,13 +47,15 @@
 my $summary = <STDIN>;
 chomp $summary;
 
-my $t = localtime ($opt_t);
+my $t = localtime ($opt_t || time);
 my ($wday,$mon,$day,$tm) = split (/\s+/, $t);
 
 my $snpp = Net::SNPP->new ($opt_q) or die;
 
-$ALERT = $opt_u ? "UPALERT" : "ALERT";
+my $ALERT=   $opt_u ? "UPALERT" : "ALERT";
+my $GROUP=   $opt_g || $ENV{MON_GROUP};
+my $SERVICE= $opt_s || $ENV{MON_SERVICE};
 
-$snpp->send ( Pager => [ @ARGV ], Message => "$ALERT $opt_g/$opt_s: $summary ($wday $mon $day $tm)" );
+$snpp->send ( Pager => [ @ARGV ], Message => "$ALERT $GROUP/$SERVICE: $summary ($wday $mon $day $tm)" );
 
 $snpp->quit;

I had to make the following changes to make snpp.alert work:

--- cvsroot/mon/alert.d/snpp.alert      2004-06-08 22:18:07.000000000 -0700
+++ cvsroot-mine/mon/alert.d/snpp.alert 2005-07-21 19:15:31.000000000 -0700
@@ -25,7 +25,7 @@
 # $Id: snpp.alert,v 1.1.1.1 2004/06/09 05:18:07 trockij Exp $
 #
 use strict;
-use vars qw /$opt_g $opt_q $opt_s $opt_t/;
+use vars qw /$opt_g $opt_q $opt_s $opt_t $opt_h $opt_l $opt_u/;
 use Getopt::Std;
 use Net::SNPP;
 
@@ -52,7 +52,7 @@
 
 my $snpp = Net::SNPP->new ($opt_q) or die;
 
-$ALERT = $opt_u ? "UPALERT" : "ALERT";
+my $ALERT = $opt_u ? "UPALERT" : "ALERT";
 
 $snpp->send ( Pager => [ @ARGV ], Message => "$ALERT $opt_g/$opt_s: $summary ($wday $mon $day $tm)" );
 

-- 
Konstantin 'Kastus' Shchuka
Unix System Administrator
Epocrates Inc.
tel 650.227.1786
fax 650.592.6995

While comparing CVS version of qpage.alert to the one I'm using
I noticed the following difference:

--- cvsroot-mine/mon/alert.d/qpage.alert        2005-06-01 17:30:57.000000000 -0700
+++ /usr/lib/mon/alert.d/qpage.alert    2001-06-26 08:45:27.000000000 -0700
@@ -11,7 +11,7 @@
 #   -l service level
 #   -q SNPP server, translates to "qpage -s"
 #
-# Jim Trocki, tr...@ar...
+# Jim Trocki, tr...@tr...
 #
 #    Copyright (C) 1998, Jim Trocki
 #
@@ -67,7 +67,7 @@
 
     else
     {
-       if (system ("qpage -p $pagedest " .
+       if (!system ("qpage -p $pagedest " .
            "'$ALERT $opt_g/$opt_s: $summary ($wday $mon $day $tm)'" .
            "2>/dev/null"))
        {


The version I'm using has "!system" which looks corect to me.
Any idea why negation was lost in CVS?

Thanks,
-- 
Konstantin 'Kastus' Shchuka
Unix System Administrator
Epocrates Inc.
tel 650.227.1786
fax 650.592.6995

This is for process.monitor so you can put the SNMP community into
mon.m4 (via the environment) rather than on the command line where
people (or Mon clients using mon.cgi) might see it.

	-- Ed

===================================================================
RCS file: RCS/process.monitor,v
retrieving revision 1.1
diff -u -r1.1 process.monitor
--- process.monitor     2005/07/06 23:32:40     1.1
+++ process.monitor     2005/07/06 23:33:06
@@ -42,7 +42,7 @@
 $ENV{'MIBS'} = "UCD-SNMP-MIB";

 getopts("c:");
-$community = $opt_c || 'public';
+$community = $opt_c || $ENV{'COMMUNITY'} || 'public';

 $RETVAL = 0;