Quotes in custom actions problem - Advanced Installer Community

We’re moving our forums to a new platform.

You can still browse and search existing topics, but you can no longer create new topics or post replies.

For questions, technical issues, or feature requests, please don’t hesitate to contact our support team at support@advancedinstaller.com.

Thank you for your understanding!

waspy
Posts: 64
Joined: Fri Oct 03, 2008 10:58 am

Quotes in custom actions problem

Hello guys and Cosmin :)
I noticed another problem:
When defining a custom action, if you specify a new parameter let's say /p and you specify its value with quotes ("") then its value gets cut if it contains commas (,). The bug is that in the dialog it shows everything correct, but when you press OK, close it and reopen to check the custom actions, you will see that it is cut...

Kind regards,
Alexei
Cosmin
Posts: 5797
Joined: Tue Jul 10, 2007 6:39 pm
Contact: Website

Re: Quotes in custom actions problem

Hi Alexei,

I'm not sure I understand how to reproduce this bug. Can you please give me more details (eventually an example)?

Regards,
Cosmin
Cosmin Pirvu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
waspy
Posts: 64
Joined: Fri Oct 03, 2008 10:58 am

Re: Quotes in custom actions problem

Hello Cosmin,
Ok, step-by step:
1. Create a custom action, let's say .NET Installer Class Action
2. Open Action data and add a new parameter p with value (put quotes!) "myModule, myAssembly". Note that quotes have been added together with the value!
3. Press Ok to close the dialog
4. Open Action data dialog again and check the value!

Cheers,
Alex
Cosmin
Posts: 5797
Joined: Tue Jul 10, 2007 6:39 pm
Contact: Website

Re: Quotes in custom actions problem

Hi Alex,

Please note that .NET Installer Class Actions do not support quotes in parameter names or values. Note that this is mentioned in the User Guide article about creating a .Net Installer class parameter. This restriction exists because quotes are added automatically to the parameter value.

Regards,
Cosmin
Cosmin Pirvu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
waspy
Posts: 64
Joined: Fri Oct 03, 2008 10:58 am

Re: Quotes in custom actions problem

Yes, I've noticed that, though as everybody I start reading after I encounter a problem :) .
I was just curious if it would be possible just to remove quotes when you close the dialog immediatly or maybe restrict users from typing them (just to improve usability)... This would make UI more robust.

Thank you very much,
Alex

P.S. Great product by the way, we started to use it for production quality installers...
Cosmin
Posts: 5797
Joined: Tue Jul 10, 2007 6:39 pm
Contact: Website

Re: Quotes in custom actions problem

Hi,

I have added on our TODO list an improvement for this and it will be available in a future version of Advanced Installer. Thank you for your suggestion.

Regards,
Cosmin
Cosmin Pirvu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Common Problems”